Opened 13 years ago
Closed 13 years ago
#18809 closed defect (bug) (fixed)
Live-update the admin bar comment bubble
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | Administration | Keywords: | dev-feedback ux-feedback |
Focuses: | Cc: |
Description
This is a regression from 3.2.
Restoring the proper classes to ensure the number updates is easy. However, we can't properly localize this, as the format is now "%s Comments" rather than "Comments %s".
Patch attached restores the proper classes. Does nothing for the localization problem, which I just don't think can be solved in JS.
Attachments (6)
Change History (13)
#1
@
13 years ago
- The bubble also appears to have an arrow on hover, overlapping with the number (see the screenshot).
- With the current format, it's now possible to see "1 Comments" or "2 Comment".
#2
follow-up:
↓ 3
@
13 years ago
- Keywords ux-feedback added
Removing the word and making do with the icon would avoid the problem.
#3
in reply to:
↑ 2
@
13 years ago
Replying to ryan:
Removing the word and making do with the icon would avoid the problem.
18809.icon-only.png shows what it looks like with 18809.patch.
#5
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Attached 18809.tweaks.diff to fix a couple of small things.
Always add the #ab-awaiting-mod span and add .awaiting-mod and .count-$awaiting_mod. This allows the pending count to live update from 0. This is an improvement over 3.2.
Centre the comment bubble when there are no pending comments.
Remove the drop down arrow which appears when hovering over the comments bubble admin menu item (requires pending comments to trigger in current trunk). Did this by only adding the sprite background to .menupop instead of all li.
Double checking CSS by somebody more familiar with the admin menu CSS (koop) is probably necessary.