Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#18825 closed defect (bug) (fixed)

Back compat issues in delete(d)_postmeta actions

Reported by: duck_'s profile duck_ Owned by: duck_'s profile duck_
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: General Keywords: has-patch
Focuses: Cc:

Description

I was looking at #18823 and noticed some backwards compatibility issues with the delete(d)_postmeta actions in 3.3.

See [18500] and #18196 for what looks like accidental backwards incompatibility.

  • The deleted_postmeta action disappeared (see delete_metadata_by_mid); this was probably a copy and paste error.
  • delete_meta( $mid ) will now run the delete_postmeta action with the post ID ($object_id) instead of the $mid.

Patch attached fixes these up to be backwards compatible with s/$object_id/$meta_id/ and adding the missing 'd'.

Attachments (1)

18825.diff (902 bytes) - added by duck_ 13 years ago.

Download all attachments as: .zip

Change History (3)

@duck_
13 years ago

#1 @ryan
13 years ago

Looks good.

#2 @duck_
13 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [18835]:

Fix back compat issues with delete_postmeta and deleted_postmeta actions as these should be passed the meta ID. Fixes #18825.

Note: See TracTickets for help on using tickets.