#18829 closed defect (bug) (maybelater)
Cleanup of postbox_classes
Reported by: | logikal16 | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.2.1 |
Component: | Template | Keywords: | has-patch |
Focuses: | Cc: |
Description
When using add_meta_box, this patch fixes the extra spaces in the meta box CSS class attribute.
This patch cleans up the postbox_classes function.
Attachments (1)
Change History (9)
#1
@
13 years ago
- Keywords needs-testing added
- Summary changed from [PATCH] Cleanup of postbox_classes to Cleanup of postbox_classes
#3
@
13 years ago
@nacin - Look at the code more closely. The line with $_GETedit? is useless. It sets $classes to a 1-element array (which the code does in 3 other instances).
It'd be easier to set the default value as an empty array, then add more classes as needed (as the patch provides).
#5
@
11 years ago
- Keywords close added; has-patch needs-testing removed
- Resolution set to maybelater
- Status changed from new to closed
Closing as maybe later. See: http://make.wordpress.org/core/2011/03/23/code-refactoring/
Note: See
TracTickets for help on using
tickets.
I'm not sure why some code here has been removed. What about the
$_GET['edit']
checks?It'd be easier if we just imploded and trim() at the end, and convert those kind-of empty arrays to
array()
.