WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#18843 closed enhancement (fixed)

Add unique admin_head action to Press This

Reported by: sillybean Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.3
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

The Press This page should have its own admin_head-foo action.

Attachments (3)

18843.diff (392 bytes) - added by sillybean 4 years ago.
Since this page doesn't use the usual admin-header.php include, I'm just hard coding the file name in this patch.
18843.2.diff (544 bytes) - added by sillybean 2 years ago.
Add unique admin_enqueue_scripts, admin_head-, admin_print_styles-, and admin_print_scripts- hooks to Press This
18843.3.diff (572 bytes) - added by sillybean 2 years ago.

Download all attachments as: .zip

Change History (10)

@sillybean4 years ago

Since this page doesn't use the usual admin-header.php include, I'm just hard coding the file name in this patch.

comment:1 @nacin4 years ago

  • Milestone changed from Awaiting Review to Future Release

Works for me. Probably worthy of a few more things as well, like admin_enqueue_scripts, admin_print_styles-*, and admin_print_scripts-*. We do this in a few other areas -- see wp_iframe().

comment:2 @sillybean2 years ago

Refreshed the patch and added the other hooks.

comment:3 @SergeyBiryukov2 years ago

Please use tabs rather than spaces for indentation (per WordPress Coding Standards).

@sillybean2 years ago

Add unique admin_enqueue_scripts, admin_head-, admin_print_styles-, and admin_print_scripts- hooks to Press This

comment:4 @sillybean2 years ago

Sorry, new IDE! Fixed and replaced the file.

@sillybean2 years ago

comment:5 @sillybean2 years ago

Updated patch to add '.php' to the hooks for consistency.

comment:6 @nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25131:

Press This: Add admin_head-like hooks that are specific to the page.

props sillybean.
fixes #18843.

comment:7 @nacin2 years ago

  • Milestone changed from Future Release to 3.7
Note: See TracTickets for help on using tickets.