Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #18857, comment 36


Ignore:
Timestamp:
01/18/2019 04:33:44 AM (7 years ago)
Author:
chriscct7
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #18857, comment 36

    initial v1  
    33As an update I took a lot of time on this with one of our company developers and we thought through a lot of the edge cases.
    44
    5 Unfortunately, from having done a lot of hours of testing and research, I don't think this is going to be possible to fix moving forward without backwards compatibility breaks. I would suggest those breaks still be made, but that this goes in first thing into 5.2, and it be announced to plugin developers straightaway so they have the entire cycle to make a very quick addition. Sadly while this would have been very easy to address & fix 7 years ago, doing so now is no longer as straightforward.
     5Unfortunately, from having done a lot of hours of testing and research, I don't think this is going to be possible to fix moving forward a without backwards compatibility break, specifically the one the patch would make. I would suggest those breaks still be made, but that this goes in first thing into 5.2, and it be announced to plugin developers straightaway so they have the entire cycle to make a very quick addition. Sadly while this would have been very easy to address & fix 7 years ago, doing so now is no longer as straightforward.
    66
    77I will put together a summary of the research tomorrow but basically the issue comes down to the fact that the best practice of allowing translations for menus has lead to a situation that it will be impossible to fix perfectly (either core will need to break BC, which I would suggest, or we will have to build a new option that new plugins can opt into to fix it moving forward, which I wouldn't recommend since all plugins using add_menu_page would also have to know to use it moving forward which is definitely not dev friendly).