WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

#18866 closed defect (bug) (duplicate)

setup-config.php styling is broken

Reported by: nacin Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: UI Keywords: has-patch
Focuses: Cc:

Description

Expected (3.2) - http://cl.ly/0u120s3f2V162v0F1105

Actual (trunk) - http://cl.ly/1v2T3w1o331l1K3k0G0e

Product of the CSS merge, I imagine.

Attachments (3)

18866.include_stylesheet.patch (1.1 KB) - added by olleicua 4 years ago.
Added a line to include the admin stylesheet here
18866_fix_styles.patch (981 bytes) - added by olleicua 4 years ago.
gradient-add.diff (1.4 KB) - added by hamptonpaulk 3 years ago.
Building on the last including gradients removing image

Download all attachments as: .zip

Change History (13)

comment:1 @SergeyBiryukov4 years ago

Actually a product of #17975, see comment:ticket:17975:10.

comment:2 @olleicua4 years ago

  • Cc olleicua@… added

This fixes it

@olleicua4 years ago

Added a line to include the admin stylesheet here

@olleicua4 years ago

comment:3 follow-up: @olleicua4 years ago

Dirp.. I just read 17975 and realized the problem with my patch here's a better one.

comment:4 in reply to: ↑ 3 @olleicua4 years ago

My patch does include a css reference to an image in the wp-admin directory. This could be an issue in the cases that 17975 was worried about but in those cases it will simply display the button with no gradient and in most cases it will do the right thing. I don't see a better way around this.

comment:5 @nacin4 years ago

Maybe we could replace this with a CSS3 gradient. We've done that in a lot of places.

I hesitate wanting to duplicate all of this CSS, but we won't have a choice.

comment:6 @olleicua4 years ago

Are there no browsers that don't yet support css gradients that we support? Also, is there a list somewhere of browsers we support?

Peace
~Sam

comment:7 @ocean903 years ago

  • Keywords has-patch added

Maybe we could replace this with a CSS3 gradient. We've done that in a lot of places.

But not all, see #16461. Maybe something for 3.4.

@hamptonpaulk3 years ago

Building on the last including gradients removing image

comment:9 @kurtpayne3 years ago

  • Cc kpayne@… added

gradient-add.diff test results:

  • FF8 - passed
  • Chrome 15 - passed
  • IE7 - square button, no gradient
  • IE8 - square button, no gradient
  • IE9 - no gradient
  • Opera - passed
  • Safari - passed

The patch's comments hint that gradients won't work on IE < 10.

18866_fix_styles.patch test results:

  • FF8 - passed
  • Chrome 15 - passed
  • IE7 - square button
  • IE8 - square button
  • IE9 - passed
  • Opera - passed
  • Safari - passed

18866.include_stylesheet.patch test results:

  • stale, won't patch cleanly

comment:10 @ocean903 years ago

  • Milestone 3.3 deleted
  • Resolution set to duplicate
  • Status changed from new to closed

It's not directly setup-config.php. More _default_wp_die_handler, called by wp_die in wp-load.php.

See #17975.

Note: See TracTickets for help on using tickets.