Opened 13 years ago
Closed 13 years ago
#18866 closed defect (bug) (duplicate)
setup-config.php styling is broken
Reported by: | nacin | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | UI | Keywords: | has-patch |
Focuses: | Cc: |
Description
Expected (3.2) - http://cl.ly/0u120s3f2V162v0F1105
Actual (trunk) - http://cl.ly/1v2T3w1o331l1K3k0G0e
Product of the CSS merge, I imagine.
Attachments (3)
Change History (13)
#3
follow-up:
↓ 4
@
13 years ago
Dirp.. I just read 17975 and realized the problem with my patch here's a better one.
#4
in reply to:
↑ 3
@
13 years ago
My patch does include a css reference to an image in the wp-admin directory. This could be an issue in the cases that 17975 was worried about but in those cases it will simply display the button with no gradient and in most cases it will do the right thing. I don't see a better way around this.
#5
@
13 years ago
Maybe we could replace this with a CSS3 gradient. We've done that in a lot of places.
I hesitate wanting to duplicate all of this CSS, but we won't have a choice.
#6
@
13 years ago
Are there no browsers that don't yet support css gradients that we support? Also, is there a list somewhere of browsers we support?
Peace
~Sam
#7
@
13 years ago
- Keywords has-patch added
Maybe we could replace this with a CSS3 gradient. We've done that in a lot of places.
But not all, see #16461. Maybe something for 3.4.
#9
@
13 years ago
- Cc kpayne@… added
gradient-add.diff test results:
- FF8 - passed
- Chrome 15 - passed
- IE7 - square button, no gradient
- IE8 - square button, no gradient
- IE9 - no gradient
- Opera - passed
- Safari - passed
The patch's comments hint that gradients won't work on IE < 10.
18866_fix_styles.patch test results:
- FF8 - passed
- Chrome 15 - passed
- IE7 - square button
- IE8 - square button
- IE9 - passed
- Opera - passed
- Safari - passed
18866.include_stylesheet.patch test results:
- stale, won't patch cleanly
Actually a product of #17975, see comment:ticket:17975:10.