WordPress.org
Get WordPress

Make WordPress Core

Opened 14 years ago

Closed 14 years ago

#18867 closed defect (bug) (fixed)

Only variables should be assigned by reference

Reported by: arena's profile arena Owned by: arena's profile arena
Milestone: 3.3 Priority: normal
Severity: trivial Version: 3.3
Component: Administration Keywords: has-patch commit
Focuses: Cc:

Description

Only variables should be assigned by reference in D:\webserver\htdocs\wordpress\wp-includes\capabilities.php at line 667

Attachments (1)

#18867.patch​ (631 bytes) - added by arena 14 years ago.

Download all attachments as: .zip

Change History (5)

@arena
14 years ago

#1 @scribu
14 years ago

  • Milestone changed from Awaiting Review to 3.3

#2 @scribu
14 years ago

  • Keywords commit added

#3 @nacin
14 years ago

The fix here would be to return $null = null, rather than null, in WP_Roles::get_roles().

Of course, the argument could be made we no longer need references here.

#4 @ryan
14 years ago

  • Resolution set to fixed
  • Status changed from new to closed

In [18956]:

Avoid 'Only variables should be assigned by reference' warning. Props arena. fixes #18867

Note: See TracTickets for help on using tickets.