WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18881 closed defect (bug) (fixed)

"Scale images to match ..." in "/wp-admin/includes/media.php"

Reported by: msi08 Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Media Keywords: has-patch
Focuses: Cc:

Description

That sentence needs a better style. It's nearly impossible to create a good translation (meaning: it should sound right) because the word order in my native language is different.

Attachments (5)

media.php.diff (768 bytes) - added by msi08 3 years ago.
media.php.diff
18881.patch (1.2 KB) - added by SergeyBiryukov 3 years ago.
18881.2.patch (1.1 KB) - added by SergeyBiryukov 3 years ago.
18881.3.patch (1.1 KB) - added by ocean90 3 years ago.
add translators comment
18881.4.patch (1.7 KB) - added by ocean90 3 years ago.

Download all attachments as: .zip

Change History (13)

@msi083 years ago

media.php.diff

comment:1 follow-up: @ocean903 years ago

  • Component changed from General to Media
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.3
  • Type changed from enhancement to defect (bug)
  • Version set to 3.3

We need also a capability check here, don't show the link if the user can't manage_options.

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

comment:2 @SergeyBiryukov3 years ago

  • Keywords has-patch added; needs-patch removed

We can also probably merge the strings into one.

Shouldn't it be "media settings" rather than "image options"?

comment:3 in reply to: ↑ 1 @azaozz3 years ago

Replying to ocean90:

We need also a capability check here, don't show the link if the user can't manage_options.

Actually that link can be removed. Put it there as during testing the users were wondering where the 1024x1024 thing came from. Perhaps we can think of a better text/explanation that won't need the link.

comment:4 @azaozz3 years ago

In [18917]:

Add cap check before showing a link to image options, improved handling for translation, props SergeyBiryukov, see #18881

@ocean903 years ago

add translators comment

comment:5 @ocean903 years ago

Do we need translators comment? See 18881.3.patch.

@ocean903 years ago

comment:6 @msi083 years ago

It's OK. It looks a bit strange because of '%1$simage options%2$s' but it's better to translate now. I'm okay with it.

comment:8 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18922]:

Add translation comment, props ocean90, fixes #18881

Note: See TracTickets for help on using tickets.