Opened 13 years ago
Closed 8 years ago
#18900 closed enhancement (wontfix)
Add a few more hide-if-no-js classes
Reported by: | johnbillion | Owned by: | rianrietveld |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 3.3 |
Component: | Administration | Keywords: | needs-testing has-patch |
Focuses: | ui, accessibility | Cc: |
Description
There are a few elements to which we could add the hide-if-no-js
class, as their functionality or setting relies on JavaScript being available.
Attachments (8)
Change History (28)
#2
@
13 years ago
Does Press This actually need JS? Many probably selectively disable JavaScript at the domain level, rather than the browser level. I'm thinking that a browser bookmarklet may still work in the case of NoScript/AdBlock, etc.
#3
@
13 years ago
The current implementation of Press This needs JS enabled for both domains, the WP install and the visited site. However if NoScript is used it's trivial to enable JS temporarily and use Press This.
#4
@
13 years ago
Attached patch adds 'hide-if-no-js' class to the "Edit Image" button when viewing a media item, as image editing required JS.
#6
@
12 years ago
- Cc xoodrew@… added
18900-header-bg.diff hides the 'Choose Image' button (from Media Library) on Custom Header & Custom Background pages. I left the direction label and added a "You need javascript to do this" message: http://cl.ly/image/3A3l2H420g40
#7
@
12 years ago
18900-header-bg.2.diff Simplifies the UI, removes the entire <p> block if no-js and displays message instead: http://cl.ly/image/2a1C1u0L1J2A
#9
@
11 years ago
- Component changed from Accessibility to Administration
- Focuses ui accessibility added
#10
@
9 years ago
- Keywords needs-refresh needs-testing added; has-patch removed
- Severity changed from minor to normal
This ticket was mentioned in Slack in #accessibility by rianrietveld. View the logs.
9 years ago
#14
@
9 years ago
- Keywords has-patch added; needs-refresh removed
Refreshed the patch with the latest 4.6 branch.
This ticket was mentioned in Slack in #core by chriscct7. View the logs.
9 years ago
#16
@
9 years ago
In 18900.3.patch src/wp-admin/includes/media.php should use double quotes to enclose the classes for consistency
This ticket was mentioned in Slack in #core by voldemortensen. View the logs.
8 years ago
#19
@
8 years ago
- Keywords close added
@Mte90, @chriscct7: src/wp-admin/includes/media.php
requires single quotes because the string is wrapped with double quotes.
18900.4.patch adds the classes only to deprecated functionality. themes.php?page=custom-background
and themes.php?page=custom-header
are only accessible when JS is disabled. We could add the class to the buttons but I don't think that the extra message is necessary.
The class inget_media_item()
seems to be useless because the whole media stuff requires JS to work properly. You can test this by opening wp-admin/media-upload.php?type=image&tab=type
in a new tab. Append &post_id=$post_id
to get the media of a specific post.
Patch. Hides the Press This link and two user settings which need JavaScript to function.