WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#18922 closed defect (bug) (fixed)

Ugly border around iframes in the WordPress Admin

Reported by: kristofferR Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Administration Keywords: has-patch
Focuses: Cc:

Description

I just tried WordPress 3.3 beta 1 and all iframes embedded in the admin area have a new horrible-looking 2px border around them. I've attached two screenshots - one from 3.2 and one from 3.3 beta 1.

The problem exists in both Firefox Nightly 10a and Safari 5.1

Attachments (4)

wordpress32noframe.png (24.5 KB) - added by kristofferR 3 years ago.
Screenshot from 3.2.1 - how it should look
wordpress33ugly.png (29.3 KB) - added by kristofferR 3 years ago.
Screenshot from 3.3 beta 1 - incredibly ugly
18922.patch (1.5 KB) - added by ocean90 3 years ago.
Use CSS reset by Eric Meyer
18922.2.diff (305 bytes) - added by andrewryno 3 years ago.

Download all attachments as: .zip

Change History (9)

kristofferR3 years ago

Screenshot from 3.2.1 - how it should look

kristofferR3 years ago

Screenshot from 3.3 beta 1 - incredibly ugly

comment:1 ocean903 years ago

  • Component changed from General to Administration
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

Already mentioned by dd32 in #18314.

Should we re-add the reset style?

ocean903 years ago

Use CSS reset by Eric Meyer

comment:2 andrewryno3 years ago

We shouldn't just throw the reset in there. Especially since a lot of the rules are now going to be duplicated. There is already a bit of resetting in wp-admin.css. When the files were merged, there were only a couple rules that were lost.

comment:3 dd323 years ago

It looks like we just need to reset iframe and a's border properties to me:

iframe,
img {
	border: none;
}

(img is for a>img in IE adds a stupid border in some locations)

andrewryno3 years ago

comment:4 andrewryno3 years ago

Attached dd32's fix in patch form.

comment:5 azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [18961]:

Remove borders from iframes and images in IE, props dd32, andrewryno, fixes #18922

Note: See TracTickets for help on using tickets.