Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#18928 closed defect (bug) (fixed)

Vimeo oEmbed API URL incorrect causing Vimeo oEmbed to not function

Reported by: l3rady Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: minor Version: 3.3
Component: Embeds Keywords: has-patch
Focuses: Cc:


'#http://(www\.)?vimeo\.com/.*#i' => array( 'http://www.vimeo.com/api/oembed.{format}', true ),

Vimeo is registered as above (/wp-includes/class-oembed.php line 36). but looking at vimeo's API their API URL is without the www.

Because the wrong URL is used embed for vimeo videos does not work.

Attachments (2)

18928.diff (1.1 KB) - added by justindgivens 7 years ago.
vimeo-oembed.php (424 bytes) - added by gluten 7 years ago.
Plugin to fix vimeo oembed provider

Download all attachments as: .zip

Change History (10)

#1 @l3rady
7 years ago

  • Cc l3rady added

7 years ago

#2 @justindgivens
7 years ago

  • Keywords has-patch added

#3 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 3.3

Confirmed. Vimeo tries to redirect to a URL without www, but apparently double-encodes query args in the process.

This works:


This doesn't:


Full URL after redirect:


Note the double-encoded video URL: http%253A%252F%252Fvimeo.com%252F30230507.

Last edited 7 years ago by SergeyBiryukov (previous) (diff)

7 years ago

Plugin to fix vimeo oembed provider

#4 @gluten
7 years ago

I whipped together a quick plugin as a hotfix for anyone who needs to fix this problem immediately.

#5 @swissspidy
7 years ago

  • Cc hello@… added

Can definitely confirm this issue. Tried to include a video for at least 30 minutes. Maybe we should tell Vimeo to fix their redirect (regarding the double encoding) since it isn't really a bug in WordPress itself?

#6 @nacin
7 years ago

  • Owner set to nacin
  • Status changed from new to accepted

The temp fix (removing www) was deployed to WordPress.com yesterday.

Let's go ahead and change this in core, since it's clear that vimeo.com is their preferred endpoint.

I'm working with Vimeo on this to ensure the old endpoint works.

#7 @ryan
7 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [18973]:

Update vimeo oembed api url. Props l3rady, justindgivens. fixes #18928

#8 @nacin
7 years ago

Vimeo was using mod_rewrite QSA without NE (noescape). That's been deployed and this is now fixed on their end as well.

Note: See TracTickets for help on using tickets.