WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 2 months ago

Last modified 2 months ago

#18937 closed enhancement (fixed)

Style Press This header like Toolbar

Reported by: andrewryno Owned by:
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.3
Component: Press This Keywords:
Focuses: ui Cc:

Description

With the admin bar now a permanent addition to the admin backend, I was thinking we should replace the old style header that's currently in the Press This bookmarklet to be the new admin bar. Since the width for the PT window is smaller, we could probably also just reduce the number of items added to it.

Attachments (1)

Omyc.png (104.4 KB) - added by andrewryno 4 years ago.
Current Press This bookmarklet with old header

Download all attachments as: .zip

Change History (14)

comment:1 @scribu4 years ago

Are you sure that's the correct screenshot?

comment:2 @andrewryno4 years ago

Yeah, looks a little different, doesn't it? ;)

Any way that can be deleted?

Version 0, edited 4 years ago by andrewryno (next)

@andrewryno4 years ago

Current Press This bookmarklet with old header

comment:3 @nacin3 years ago

  • Keywords needs-patch added

Needs patch.

comment:4 @nacin3 years ago

  • Keywords needs-ui added

comment:5 @azaozz3 years ago

Not sure we need to actually add the admin bar there, perhaps just style the header to look similarly? Press This has a specific purpose and adding links/menus there isn't needed and won't work as expected.

comment:6 @jane3 years ago

I can't imagine why the admin bar would be appropriate in Press This. I agree that it should be styled to match, but putting update notices, Add New, etc across the top are outside the scope of a popup bookmarklet whose sole purpose is to post something you found on the web. I would vote no.

comment:7 @nacin3 years ago

I agree. Styles only, not full functionality.

comment:8 @helen15 months ago

  • Focuses ui added
  • Keywords needs-ui removed

comment:9 @ocean9015 months ago

  • Summary changed from Add admin bar to press this bookmarklet to Style Press This header like Toolbar

comment:10 @Michael Arestad3 months ago

We've added similar styling in the Press This feature plugin. It currently looks like this:
https://cldup.com/Dds_-aHSJM-3000x3000.png High res: https://cloudup.com/cMYJPVkYVzz

Last edited 3 months ago by Michael Arestad (previous) (diff)

comment:11 @kraftbj2 months ago

  • Resolution set to worksforme
  • Status changed from new to closed

Updated styling in the Press This Revamp in [31534] via #31373.

comment:12 @DrewAPicture2 months ago

  • Keywords needs-patch removed
  • Milestone Awaiting Review deleted

comment:13 @SergeyBiryukov2 months ago

  • Milestone set to 4.2
  • Resolution changed from worksforme to fixed
Note: See TracTickets for help on using tickets.