Opened 13 years ago
Closed 10 years ago
#18946 closed defect (bug) (fixed)
Too long tags make the cross not moving anymore.
Reported by: | jonezjea | Owned by: | azaozz |
---|---|---|---|
Milestone: | 4.2 | Priority: | low |
Severity: | normal | Version: | 3.2.1 |
Component: | Editor | Keywords: | has-patch |
Focuses: | ui, administration | Cc: |
Description
If you have a long tag like a long title of a book or movie title or game title and you more the cross doesn't move with the tags.
Look to the screenshot for more info
Attachments (5)
Change History (23)
#3
@
13 years ago
- Keywords reporter-feedback removed
Happens in Firefox 7 too. Steps to reproduce:
- Add a few short tags (as on the screenshot).
- Add a long tag (e.g. "The Legend of Zelda: Oracle of Seasons and Oracle of Ages").
- Scroll a bit to the right. All tags will move, but the icons will stay in place.
#4
@
13 years ago
Just updated my version of Google Chrome to .4 at the end and the problem is still here.
Tested it also in FireFox 8.0 Beta 4 and same problem
#5
@
10 years ago
- Focuses ui administration added
- Keywords needs-patch added
- Severity changed from minor to normal
This still happens on 4.0 (you have to do the short tags before the long one or you won't be able to reproduce).
Example:
Before scrolling:
http://screencloud.net/v/Ei7Q
After scrolling:
http://screencloud.net/v/z7q7
This ticket was mentioned in Slack in #core by chriscct7. View the logs.
10 years ago
#7
@
10 years ago
Here's a patch. I'm not sure I named the patch correctly, let me know if not. This was just a couple of css changes. I changed overflow: auto
to overflow: hidden
and added breakword
to the tag itself.
#9
@
10 years ago
The patch works and looks good to me.
The only thing is that words longer than 35 characters are not displayed properly. Characters at the end of the word get cut off. I'm not sure if this is behavior that should be addressed or fixed.
#10
follow-up:
↓ 11
@
10 years ago
The odds of someone wanting to use a word that's longer than 35 characters is considerably low. There are only a handful of languages with words that are even that long*, and most of those words are not what you would call commonly used words.
This might be a case that we just want to use design for the vast majority for.
#11
in reply to:
↑ 10
;
follow-up:
↓ 12
@
10 years ago
Replying to chriscct7:
The odds of someone wanting to use a word that's longer than 35 characters is considerably low. There are only a handful of languages with words that are even that long*, and most of those words are not what you would call commonly used words.
This might be a case that we just want to use design for the vast majority for.
This was my thought exactly, but I still wanted to address this to verify.
Then the patch looks good to me :)
#12
in reply to:
↑ 11
@
10 years ago
Replying to carolinegeven:
Agreed. I'll bring it up in dev chat today to merge into core
Replying to chriscct7:
The odds of someone wanting to use a word that's longer than 35 characters is considerably low. There are only a handful of languages with words that are even that long*, and most of those words are not what you would call commonly used words.
This might be a case that we just want to use design for the vast majority for.
This was my thought exactly, but I still wanted to address this to verify.
Then the patch looks good to me :)
#13
@
10 years ago
The only thing is that words longer than 35 characters are not displayed properly. Characters at the end of the word get cut off. I'm not sure if this is behavior that should be addressed or fixed.
It's probably worth adding text-overflow: ellipsis;
for longer words, just in case.
#14
@
10 years ago
- Priority changed from normal to low
I cannot reproduce the original issue.
Removing white-space: nowrap;
will make sure longer sentences are wrapped.
Adding max-width: 100%;overflow: hidden;text-overflow: ellipsis;
will make sure long words without spaces are cut of wil an ellipsis.
Tags are supposed to be short though. Currently the end of the tag is just cut off...
Updated @trishasalas' patch.
#15
@
10 years ago
Avryl, Thanks for doing this! I was playing with this some last night and was unable to get ellipses to work. Looks like I was should have used max-width rather than width.
When not using ellipses long phrases were wrapped, long words were just cut off.
What platform are you using? Looks fine to me on FF7 on Linux or Windows.