WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#18992 closed defect (bug) (fixed)

When reopening "Add Photos" postbox in Press This, "Loading" icon never goes away

Reported by: andrewryno Owned by: duck_
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Press This Keywords: has-patch
Focuses: Cc:

Description

Steps to reproduce:

  • Open Press This editor
  • Click "Add Image" icon
  • Click "Cancel"
  • Click "Add Image" icon again

Loading notice still stays in place. Patch attached.

Attachments (2)

18992.diff (643 bytes) - added by andrewryno 9 years ago.
18992.2.diff (889 bytes) - added by duck_ 9 years ago.

Download all attachments as: .zip

Change History (6)

@andrewryno
9 years ago

#2 @SergeyBiryukov
9 years ago

  • Milestone changed from Awaiting Review to 3.3

Small patch, seems to work. Moving for review.

@duck_
9 years ago

#3 @duck_
9 years ago

Fix is good, but I wonder if it's worth it to have the #waiting div always there and hidden/shown by JavaScript rather than using JS to keep adding and removing it. See attached patch.

#4 @duck_
9 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [19229]:

Stop multiple loading spinners showing when repeatedly accessing Press This Add Photos box. Fixes #18992.

Note: See TracTickets for help on using tickets.