Superfluous check in WP_Users_List_Table::display_rows()

[scribu]

Specifically, this one:

if ( is_multisite() && empty( $role ) )
    continue;

It seems to have been a misguided attempt to fix something that should have been (and currently is) handled at the SQL level: #12711

[scribu]

Also note that single_row() is perfectly capable of handling a user without a role on the current blog (it just shows 'None' in the Role column).

[scribu]

While we're at it, we can just let single_row() get the role for itself. See 18995.2.diff​.

[nacin]

Works for me.

[coffee2code]

Patch no longer applies cleanly against trunk as of r21435.

[wonderboymusic]

The role logic is a lot more robust now - we also shouldn't change the method signature 4 years later