Make WordPress Core

Opened 3 years ago

Last modified 2 years ago

#18995 new defect (bug)

Superfluous check in WP_Users_List_Table::display_rows()

Reported by: scribu Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.2.1
Component: Users Keywords: has-patch needs-refresh
Focuses: Cc:


Specifically, this one:

if ( is_multisite() && empty( $role ) )

It seems to have been a misguided attempt to fix something that should have been (and currently is) handled at the SQL level: #12711

Attachments (2)

18995.diff (675 bytes) - added by scribu 3 years ago.
18995.2.diff (1.8 KB) - added by scribu 3 years ago.

Download all attachments as: .zip

Change History (6)

scribu3 years ago

comment:1 scribu3 years ago

Also note that single_row() is perfectly capable of handling a user without a role on the current blog (it just shows 'None' in the Role column).

scribu3 years ago

comment:2 scribu3 years ago

While we're at it, we can just let single_row() get the role for itself. See 18995.2.diff.

comment:3 nacin3 years ago

Works for me.

comment:4 coffee2code2 years ago

  • Keywords needs-refresh added
  • Version set to 3.2.1

Patch no longer applies cleanly against trunk as of r21435.

Note: See TracTickets for help on using tickets.