WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19004 closed defect (bug) (fixed)

Ipad - wp_editor 'add media' is out of view when used on front-end

Reported by: anointed Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Editor Keywords: reporter-feedback
Focuses: Cc:

Description

To reproduce:

  1. add wp_editor() to the front end of a website page that is very long. Place the editor on the bottom of the page.
  2. Click the 'add media' button

Now you will notice that you can't see the add media lightbox unless you scroll all the way to the top of the page.

*another thing I noticed on the ipad is that when clicking the add-media button, that the screen does not darken like it does on the regular computer. This leads to even more confusion as you have no idea that there is now a lightbox up top out of view.

Change History (11)

comment:1 anointed2 years ago

checked the 3.3beta2 and the problem still exists on the ipad.

comment:2 nacin2 years ago

  • Milestone changed from Awaiting Review to 3.3
  • Owner set to azaozz
  • Status changed from new to assigned

comment:3 azaozz2 years ago

Sounds like another thickbox problem/conflict. Does that happen with any theme or just some themes?

comment:4 nacin2 years ago

  • Keywords reporter-feedback added

comment:5 trepmal2 years ago

Not as issue on my used-to-be-P2 theme (using 3.3-beta3-19254). Lightbox stays fixed/visible anywhere I scroll, whether the editor is placed at the bottom or top of a long page.

Though the multi-file uploader still offers the the "Drop files here" and "Select Files" options on ipad, neither of which are usable. Should I create a new ticket for that?

Last edited 2 years ago by trepmal (previous) (diff)

comment:6 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [19335]:

Don't show the uploader on iPads (it's pointless), fixes #19004

comment:7 azaozz2 years ago

Seems the thickbox bug appears only on some themes. If we can pinpoint what css causes it, probably can override/reset it.

comment:8 follow-up: WraithKenny2 years ago

Haven't tried it, but is it possible to upload images out of the photo library on iPad (or android)?

The css fixed positioning has been an issue with iOS Safari, but that should be cleaned up in the later versions, but apparently only when the proper configuration of <meta name="viewport" content="width=device-width, user-scalable=no"> or some such (this would explain why some themes work but not others). Could also affect Android, see: http://caniuse.com/#search=fixed

Version 0, edited 2 years ago by WraithKenny (next)

comment:9 anointed2 years ago

@azaozz
Is the fix your posting by not showing the media uploader on ipads one that only disables the uploader?

While it is correct that I cannot download images from my ipad, I would obviously still need the ability to activate the media uploader so that I can select the library browser in order to insert images into a post.

comment:10 in reply to: ↑ 8 azaozz2 years ago

Replying to WraithKenny:

Uh, I hate user-scalable=no, probably one of the coolest things on small screens is the ability to enlarge something. Seems we will have to keep it if it fixes position:fixed though.

@anointed of course, the media library works. Have a look there :)

comment:11 WraithKenny2 years ago

I'm testing on trunk with the iPhone/iPad simulator, and zoom/scaling seems to not work anyway... is it disabled with media queries?

Note: See TracTickets for help on using tickets.