"Show on screen" checkboxes inconsistency with CPT

[SergeyBiryukov]

With the ​"Book" CPT example from Codex:

On the initial "Edit Book" screen load (i.e. when there's no metaboxhidden_book record in wp_usermeta), all meta boxes are displayed, but only "Featured Image" is checked in "Show on screen" options (see the screenshot).

[SergeyBiryukov]

Being called from meta_box_prefs() and do_meta_boxes(), get_hidden_meta_boxes() returns different results, due to different $screen values.

In meta_box_prefs(), it's:

WP_Screen Object( [id] => book, [base] => post, ... )

In do_meta_boxes(), it's:

stdClass Object( [id] => book, [base] => book )

Note the difference in base value.

Not sure what the preferred option is, but 19010.patch​ at least makes it consistent.

[scribu]

This should be looked at, as part of the work on screens.

[ryan]

Is this still a problem after [19013]? We should try to pass the current screen object instead of IDs.

[SergeyBiryukov]

Fixed in [19013].