WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19016 closed defect (bug) (fixed)

wpdb::_insert_replace_helper() incorrectly quotes prepare placeholders

Reported by: duck_ Owned by: duck_
Milestone: 3.4 Priority: normal
Severity: normal Version: 2.8
Component: Database Keywords: has-patch
Focuses: Cc:

Description

wpdb::_insert_replace_helper() implodes $formatted_fields with "','" this produces something like:

INSERT INTO `wp_terms` (`name`,`slug`,`term_group`) VALUES ('%s','%s','%d')

and not

INSERT INTO `wp_terms` (`name`,`slug`,`term_group`) VALUES (%s,%s,%d)

This is inherited from wpdb::insert(), see [10724], so marking version as 2.8 rather than 3.0.

Attachments (1)

19016.diff (575 bytes) - added by duck_ 2 years ago.

Download all attachments as: .zip

Change History (3)

duck_2 years ago

comment:1 duck_2 years ago

  • Milestone changed from Future Release to 3.4

comment:2 duck_2 years ago

  • Owner set to duck_
  • Resolution set to fixed
  • Status changed from new to closed

In [19692]:

Stop quotes being incorrectly added to prepare placeholders in wpdb::_insert_replace_helper(). Fixes #19016.

Note: See TracTickets for help on using tickets.