#19020 closed defect (bug) (fixed)
Content Updates for Help Tabs
Reported by: | dougwrites | Owned by: | jane |
---|---|---|---|
Milestone: | 3.3 | Priority: | low |
Severity: | normal | Version: | 3.3 |
Component: | Administration | Keywords: | has-patch |
Focuses: | Cc: |
Description
For updates, corrections, consistency, and clarity in what the contextual help tabs say with the new version and changed features.
Will file a separate ticket for a pair of screens: Freedoms and About This Version currently don't have specific help content.
I am working on an omnibus patch, as we did in 3.1 and 3.2, to put in these changes, as well as any better phrasing people have over the next few days. The timing does seem short before string freeze.
Attachments (35)
Change History (126)
#2
@
13 years ago
File successfully uploaded, of my edits, for anyone to peruse who wants to seek even better phrasings or just read all of the tabs in one sitting.
#4
@
13 years ago
I didn't see the copy for the My Sites page (maybe I'm just blind?).
The copy there is written in the third-person rather than the second-person like the rest of the site, and should - if nothing else - be rewritten to match the style of all the other help copy.
#5
@
13 years ago
trepmal, how about:
for My Sites (which only appears in the individual site nav if it's a multisite installation)
This screen shows you all of your sites in this network, and also allows you to set a primary site. You can use the links under each site to visit either the front end or the dashboard for that site.
Any more changes to this tab?
#7
@
13 years ago
Some tabs should add a line of help depending on whether they are or are not part of a multisite installation. I can do that for when that bit is not in multisite (say Media Settings).
But could anyone help me for when the line of help text is only there if it is multisite, like in Install Themes (wp-admin/theme-install)?
#8
@
13 years ago
I'm almost done with the omnibus patch, for 30 screens. Will try the ternary operator for the multisite/not-multisite differences, as is already done in Media Settings.
#9
@
13 years ago
Just uploaded all my proposed changes in an omnibus patch. It includes some small changes I made from the PDF of four days ago. Will also post an Errata file summarizing those further changes.
@
13 years ago
Same patch, with 3 typos fixed (extra space, missing to, phantom Media Settings MS test)
#19
@
13 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In [19122]:
#22
@
13 years ago
Still missing a sidebar in wp-content/themes/twentyeleven/inc/theme-options.php. Getting
Fatal error: Call to a member function set_help_sidebar() on a non-object
when I try to to put in code like the other help tabs.
#23
@
13 years ago
admin_menu is too early. We were doing it wrong to begin with. We'll need to move that to load-$pagenow.
#24
@
13 years ago
First pass at adding theme options help for twentyeleven. We need to decide what to do with screens that don't have multiple tabs. Should add_help_tab() accommodate passing just a help string and take care of setting the tab title to a default string? Also, this patch breaks twentyeleven compat with < 3.3, if we care.
#25
@
13 years ago
Also, this patch breaks twentyeleven compat with < 3.3, if we care.
A method_exists() before the add_action() makes sense.
That said, perhaps we should sneak in a function __call( $name, $args ) {}
in WP_Screen. I've been thinking about this a lot. Then things will fail silently when called in older versions. Will only work for 3.3+, but can help as we start to probably pull more methods into the screen bits. (Perhaps some form of settings, etc.) Of course, it'll also fail silently with a typo. Perhaps we can trigger_error() E_NOTICE but otherwise let it slide -- look ma, no fatals.
#26
@
13 years ago
Just uploaded a file with proposed heading titles for breaking up each tab into one or more sub-sections. Jane, can you approve, edit, or modify the general direction and style of the titles?
Also, do we have finalized code for this, particularly for tabs without screen options and tabs with only one sub-section but a specific heading title? (i.e., "Link Categories" instead of "Screen Info")
#27
@
13 years ago
Actually, scratch that part of my question about screen options, since they're no longer attached to a place within the help tabs; I knew that :)
So is there a code decision yet about singletons?
#30
follow-up:
↓ 31
@
13 years ago
The help tab for Widgets is going to need more attention, to address the new Inactive Sidebars boxes. Also, is there a set period of time or an event after which these boxes disappear for a given theme?
#31
in reply to:
↑ 30
;
follow-up:
↓ 32
@
13 years ago
Replying to dougwrites:
Also, is there a set period of time or an event after which these boxes disappear for a given theme?
No. The consensus was to store old sidebars persistently rather than temporarily, in order to make sure they're always available when switching back: ticket:17979:74.
#32
in reply to:
↑ 31
@
13 years ago
The consensus was to store old sidebars persistently rather than temporarily, in order to make sure they're always available when switching back: ticket:17979:74.
That may change though, see the recent discussion in ticket:19291:7.
@
13 years ago
Adding in info on widget loss when switching themes and sidebar 'saving' (though I did not put in for how long as that's in flux).
@
13 years ago
Users - Adding in Multisite info (remove instead of delete), row actions, customizing
@
13 years ago
Differences between adding new users in multisite and single, add new and add existing, emails etc
@
13 years ago
Adds tabs for Help Text sections on "All Posts", "All Pages", "Media Library", and "Upload New Media" screens.
@
13 years ago
Added more help tabs. Updated some copy (old upload copy, references to Admin bar -> Toolbar)
@
13 years ago
User edit screen - It's the Toolbar, baby, and it's here to stay. (I did not change the instances of Admin Bar in the page content to Toolbar, only the help box.)
@
13 years ago
Tools - Splits "Press This" and Cat/Tag Switcheroo into two panes. Made it more clear that "Use This" referenced a link by putting quotes around it.
#40
@
13 years ago
Updated user-edit.php and then the tools trifecta (with a sad, sad joke in the description -- It's been a weird day).
I did NOT change the body of 'User Edit', even though it still calls the Toolbar by it's Admin Bar name. I can change that, but this ticket was for Help Screens and it felt out of scope.
@
13 years ago
Options Screens (Inlcuding the network one that pops up when you start setting up MultiSite)
#41
@
13 years ago
Options Screens uploaded in bulk. Writing options has a multisite catch so than Networked installs don't get info about how to email update their site.
#42
@
13 years ago
Themes main page updated - I did break apart the $help into two tabs, which let me toss in a MultiSite 'You can't install themes here, neener' heads up.
@
13 years ago
Include Welcome Box when discussing Screen Options; don't mention Plugins if part of a multisite
#44
@
13 years ago
Just added two a la carte patches to mop up some more stuff in a couple of files which have recently had commits.
Add/Edit New Post/Page had a missing "to" which has been way too persistent, like the "but here some of the" in [19402];
Dashboard-Home needs to have Help Content mention the Screen Options check-box for "Welcome" but not mention the Plugins check-box for multisite installations (which cannot have that box).
#45
follow-up:
↓ 46
@
13 years ago
/wp-admin/network
needs an update, see
http://core.trac.wordpress.org/browser/trunk/wp-admin/network.php#L111
#46
in reply to:
↑ 45
@
13 years ago
Replying to ocean90:
/wp-admin/network
needs an update, see
http://core.trac.wordpress.org/browser/trunk/wp-admin/network.php#L111
Diff attached for that.
#51
@
13 years ago
Chexee, per our discussion at the Meetup tonight, the two things were: 1) the admin pages with varying spellings of frontend/front end were wp-admin/my-sites.php and wp-admin/network/sites.php; we should make that consistent either way;
2) The complex file with 3 different manifestations is wp-admin/plugins.php ("Installed Plugins"). It shows up in the single-site admin menu (for which it's accurate) but also in the site admin menu AND network admin menus of a multisite. In those cases, it should reflect that plugins can't be installed from site admin but need to be installed for sites in the network admin. I think the long ternary I came up with in line 323 covers all three cases by letting both parties in the multisite equation know which side can/can't do what.
#52
in reply to:
↑ 47
@
13 years ago
- Cc jeremy@… added
Replying to ocean90:
Ipstenu, it's the content,
Howdy dropdown
is gone.
Indeed, Network Admin is now available under "My Sites". See my diff. if that helps.
@
13 years ago
Hides some help text in multisite that describes some General Settings not available in ms installs
#58
@
13 years ago
Just added two more small patches for a la carte fixes on recent commits. They should make General Settings accurate for multisite and remove a repeated phrase on Manage Themes (which looks like padding on single-site and just plain bad on multisite).
#60
follow-up:
↓ 61
@
13 years ago
- Keywords copy-feedback added
Whew. There are a lot of patches on this ticket. With the exception of the following five patches, every patch has been reviewed and committed (or was made obsolete by another patch/commit).
I'd like to get some copy feedback before committing the remaining patches. Most are minor changes.
#61
in reply to:
↑ 60
@
13 years ago
Replying to koopersmith:
I'd like to get some copy feedback before committing the remaining patches. Most are minor changes.
Doing a review this afternoon of all the Help screens in admin and patching for some text updates. Since these aren't committed, will just base updates on what's there. Some of the language is inconsistent in the patches due to multiple authors. Really ought to make a styleguide for these.
#65
@
13 years ago
- Owner set to jane
jane will be reviewing all existing language (committed or not) and creating any remaining tabs.
#66
in reply to:
↑ 64
@
13 years ago
Replying to jane:
Replying to Zeo:
Which one is correct? Multi-site or multisite?
No hyphen. Multisite.
http://core.trac.wordpress.org/browser/trunk/wp-admin/themes.php#L51 s/MultiSite/Multisite. See: [19473]
http://core.trac.wordpress.org/browser/trunk/wp-admin/includes/admin.php#L61 s/Multi-Site/Multisite
http://core.trac.wordpress.org/browser/trunk/wp-admin/my-sites.php#L40 s/Multi-site/Multisite
http://core.trac.wordpress.org/browser/trunk/wp-includes/ms-functions.php#L3 s/Multi-site/Multisite
#68
@
13 years ago
Since [19237], Twenty Eleven has an unused "Screen Info" string in .pot file due to missing textdomain. It relied on the string from the main translation files, which was removed in [19493].
We need to add textdomain and perhaps also change the string to "Overview" for consistency. 19020.twenty-eleven.patch does both.
#80
follow-up:
↓ 82
@
13 years ago
Please review http://core.trac.wordpress.org/attachment/ticket/19020/19020-zeo-2011-theme-options.php.diff. If good please commit.
#81
@
13 years ago
Under 2011 Theme Options > Layout, "Content on left", "Content on right" should be change to "Sidebar on left", "Sidebar on right" to make it consistent with the help tabs yes?
#82
in reply to:
↑ 80
@
13 years ago
Replying to Zeo:
Please review http://core.trac.wordpress.org/attachment/ticket/19020/19020-zeo-2011-theme-options.php.diff. If good please commit.
I'm not in favor of the proposed change. The word Default is there deliberately because the user can choose the alternate layouts on the page editor screens as desired. No commit.
Also, in general: it's up to the commit team to decide what to commit or not. The act of posting a patch to Trac is a request for it to be committed, so there's no need to ask for it to be committed in the comment.
#83
follow-up:
↓ 87
@
13 years ago
@jane Okay. But it should be consistent right? Why the Color Scheme is not Default Color Scheme? Do look closely in the Theme Options help tabs, Twenty Eleven Theme Options and then the Codex http://codex.wordpress.org/Appearance_Theme_Options_Screen
#84
@
13 years ago
Originally "Layout" is "Default Layout" see: http://core.trac.wordpress.org/browser/tags/3.2/wp-content/themes/twentyeleven/inc/theme-options.php#L261. That's why the help tab uses "Default Layout" see: http://core.trac.wordpress.org/browser/tags/3.2/wp-content/themes/twentyeleven/inc/theme-options.php#L94
#85
@
13 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Upon inspection, I agree with "Layout", but don't feel the need for the other changes. Sorry the patch was missed.
#86
in reply to:
↑ 75
;
follow-up:
↓ 88
@
13 years ago
Replying to nacin:
In [19512]:
The Dashboard Overview tab still reads: You can get help for any screen by clicking the Help tab in the top bar.
"in the top bar" should be replaced with something like "found at the top right" or s/in/below/.
For comparison this is 3.2.1:
You will find helpful tips in the Help tab of each screen to assist you as you get to know the application.
#87
in reply to:
↑ 83
@
13 years ago
- Keywords copy-feedback removed
Replying to Zeo:
@jane Okay. But it should be consistent right? Why the Color Scheme is not Default Color Scheme?
Because you can only ever have one color scheme for the whole site. You can choose layout on a page-by-page basis.
#88
in reply to:
↑ 86
@
13 years ago
Replying to duck_:
"in the top bar" should be replaced with something like "found at the top right" or s/in/below/.
"in the upper corner" would work, and would require any RTL changes.
#89
@
13 years ago
For the sake of minimizing the number of strings in the POT file, pls take a look at these strings below.
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-media.php#L30
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-reading.php#L50
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-permalink.php#L32
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-permalink.php#L39
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-writing.php#L22
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-discussion.php#L22
"You must click the Save Changes button at the bottom of the screen for new settings to take effect."
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-general.php#L70
"Remember to click the Save Changes button at the bottom of the screen for new settings to take effect."
http://core.trac.wordpress.org/browser/trunk/wp-admin/options-permalink.php#L23
"When making changes, you must click the Save Changes button at the bottom of the screen for the new settings to take effect."
Basically it's the same. Can we choose the best one and only use that?
I have a nice pdf of all my suggested changes which is currently too big but has nice highlighting of strikethrough/underline changes for the whole Beta. Will upload soon.