Broken pointers if attached to elements visible after scrolling page

[kkarpieszuk]

If you attach pointer for example to #footer it looks bad.

Try this code:

add_action( 'admin_enqueue_scripts', 'my_admin_enqueue_scripts' );
function my_admin_enqueue_scripts() {
    // Using Pointers
    wp_enqueue_style( 'wp-pointer' );
    wp_enqueue_script( 'wp-pointer' );

    // Register our action
    add_action( 'admin_print_footer_scripts', 'my_admin_print_footer_scripts' );
}

function my_admin_print_footer_scripts() {
    // This will run during footer scripts, use jQuery to show the pointer here.
    $pointer_content = '<h3>Test</h3>';
    $pointer_content .= '<p>Test';
?>
<script type="text/javascript">
//<![CDATA[
jQuery(document).ready( function($) {
    $('#footer').pointer({
        content: '<?php echo $pointer_content; ?>',
        position: 'bottom',
    }).pointer('open');
});
//]]>
</script>
<?php
}

as you can see, arrow is over the infobox and even infobox is under footer. ​http://minus.com/mbde0EcLFG

I think it heppens only when footer is not visible after page load. When i tried this on some admin page, where scroll bar is not visible (page is shorter than window height) pointer was ok.

[kkarpieszuk]

screenshot

[blepoxp]

I'm not a JS pro and there is probably a better place to put this in wp-pointer.js but the attached patch works for me.

[blepoxp]

Reposition on screen resize or scroll

[jane]

Since we are not doing any below-fold pointers in this release, I don't think this should be a blocker. @koopersmith: In or out?

[ocean90]

A blocker not, but to re-position the pointer if the screen will be resized makes sense.

[koopersmith]

Misplaced arrows should no longer be an issue (the positioning code was simplified when we added the new pointer styles).

We should reposition the pointers when the screen is resized, but should not do so every time the resize event is fired. An appropriate balance between accuracy and speed would be to hide the pointer as the window begins to resize, and show it again (thereby repositioning it) once the resize has completed (due to the resize event not being triggered for a set amount of time).

[westi]

Replying to koopersmith:

Misplaced arrows should no longer be an issue (the positioning code was simplified when we added the new pointer styles).

We should reposition the pointers when the screen is resized, but should not do so every time the resize event is fired. An appropriate balance between accuracy and speed would be to hide the pointer as the window begins to resize, and show it again (thereby repositioning it) once the resize has completed (due to the resize event not being triggered for a set amount of time).

Agreed.

I think this can wait for 3.3.1 ?

[jane]

@westi: Yes. Assuming 80%+ with a regular screen that's not being resized on the single instance they see the pointers before dismissing them, we shouldn't be bothering with this. They are they and they work as intended (show up, go away). Can refine in future versions.

[koopersmith]

In [19713]:

Improve pointer collision handling. fixes #19021.