#19042 closed defect (bug) (fixed)
RTL fixes for 3.3
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.3 |
Component: | RTL | Keywords: | |
Focuses: | Cc: |
Description (last modified by )
It's time for a main 3.3 RTL ticket - I know it's usually better to split things up (see {38} ) but I think that at this point it's better to consolidate issues so we can all work on this together.
The attached patch refreshes admin-bar-rtl completely to account for 3.3 changes, fixes a bug in the uploader RTL css, and with the admin footer.
The patch also consolidates fixes for:
Attachments (17)
Change History (47)
#3
follow-up:
↓ 4
@
13 years ago
I've noticed a few RTL issues with the admin bar in Internet Explorer. For example, in IE9, the white update count circle doesn't appear correctly and the little downward pointing arrows don't appear at all (or appear in the wrong place with the patch proposed in #19086).
Also, in IE7, everything in the admin bar disappears altogether on hover.
Is it best to create separate tickets for these issues, or just discuss them here?
#4
in reply to:
↑ 3
;
follow-up:
↓ 5
@
13 years ago
Replying to rosshanney:
The bubble looks fine to me:
and the arrows are most likely going to be removed (they were meant to appear on hover if the menus needed clicks to open).
#5
in reply to:
↑ 4
@
13 years ago
I'm referring to the available update count notification (the white circle), not the comments bubble.
Replying to azaozz:
and the arrows are most likely going to be removed (they were meant to appear on hover if the menus needed clicks to open).
Ah, I see. Fair enough!
#6
@
13 years ago
19042.help-and-screen-options.patch contains RTL adjustments for Help and Screen options since [19131].
#7
follow-up:
↓ 8
@
13 years ago
19042.toggle-arrow-cleanup.patch cleans up unused .toggle-arrow
class styles.
Being in RTL sections of colors-*.css
files, they:
- Don't have
.rtl
prefix. - Are overridden by
editor-buttons.css
.
#8
in reply to:
↑ 7
@
13 years ago
Replying to SergeyBiryukov:
- Are overridden by
editor-buttons.css
.
Editor-buttons is supposed to hold all styling for outside the editors (mostly buttons and toolbars) as they can be used on the front end now. For the blue theme and specific RTL for the admin we could use a bit more specific selectors, i.e. prefix the selectors by one of the container classes/IDs like #wpcontent
, #wpbody
, .wrap
, etc. as editor-buttons.css is loaded after the RTL stylesheets (mid-page).
#11
@
13 years ago
19042.welcome-panel.patch contains RTL adjustments for Welcome Panel as per [19163].
#12
@
13 years ago
The plugin update message on the plugins screen is a little out of place.
Please see 19042.plugin-update-message.diff.
#13
@
13 years ago
The collapse icon points the wrong way when the admin menu is collapsed (.folded). Also, the shadows on admin menu flyouts don't seem quite right.
#14
@
13 years ago
The "Howdy" section of the admin bar no longer appears at the far left. I think caused by [19230].
Please see 19042.admin-bar-howdy-menu.diff
#16
@
13 years ago
Submenu flyout jumps on focus: http://cl.ly/0v0a3C1v1M3d3z0E3w1Y
19042.flyoutjump.diff should fix it.
@
13 years ago
When deactivating a plugin (and I'm not sure where else) the text alert reads .Plugin deactivated
(sic)
#18
@
13 years ago
That being said, my latest patch on #18654 -- 18654.with-201-percent-more-rtl.diff -- also happens to fix the user menu in RTL. I'm cross-posting so it doesn't get lost in the shuffle somehow (thanks, jjj!)
#21
@
13 years ago
admin-menu-rtl.patch will fix all RTL issues with the admin menu, includes the issue mentioned by helenyhou in comment:16.
#23
@
13 years ago
- Keywords needs-patch added; has-patch removed
- Priority changed from high to normal
- Severity changed from major to normal
#25
@
13 years ago
Help styling is broken: http://cl.ly/2C331K2P2t2M0C0q2K0n
Working on a patch.
#26
@
13 years ago
19042.helptabs.diff fixes help styling, probably broken in r19361.
In [19080]: