WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#19043 closed defect (bug) (fixed)

Browser nag should not appear when user *cannot* upgrade.

Reported by: cyberskull Owned by:
Milestone: WordPress.org Priority: normal
Severity: normal Version: 3.2.1
Component: General Keywords: has-patch close
Focuses: Cc:

Description

The WordPress browser nag should not appear in situations where upgrading the browser in question is impossible, such as when the browser is the last supported version for a particular operating system.

For example, the browser nag should not appear with the following browser/OS combinations:

  • Safari 5.0.6 on Mac OS X 10.5.8
  • Firefox 3.6.17 on Mac OS X 10.5.8
  • Opera 10.63.8450 on Mac OS X 10.5.8
  • Internet Explorer 8 on Windows XP

It is frustrating to users to be told to do something that is quite impossible.

Attachments (2)

browsehappy.diff (1.5 KB) - added by tw2113 5 years ago.
Added some of the suggested text to the browse happy messages
ie-browsehappy.png (39.9 KB) - added by MikeHansenMe 4 years ago.
current message for ie 7 users

Download all attachments as: .zip

Change History (12)

#1 @nacin
5 years ago

Suggesting wontfix. They can upgrade — to a different browser. Perhaps we can make that more clear if we know they're stuck. But they're not using an up-to-date browser. There may be security concerns, there may be web standards concerns. That they're running an old OS is pretty much moot. They still need to know their browser is insecure or old.

#2 @kurtpayne
5 years ago

  • Cc kpayne@… added

I propose two options:

Option 1:

If browsehappy detects that a user's browse cannot be upgraded on their current platform, give the user a new message: "This browser is no longer actively updated on your operating system, for the best WordPress experience, you should switch to a new browser like Chrome, Safari, Opera, or Firefox." (with links embedded)

Option 2:

Update the old / insecure messages with an extra clause: "... for the best WordPress experience, please update your browser, or use the latest version of a different browser like Chrome, Safari, Opera, or Firefox." (with links embedded)

#3 @SergeyBiryukov
5 years ago

I like option 2. Not sure about the embedded links though. "For the best WordPress experience, please update your browser, or use the latest version of a different browser" seems enough.

#4 follow-up: @kurtpayne
5 years ago

  • Cc kpayne@… removed

@SergeyBiryukov, it seems like there's a connection that can be made here with the browsehappy data since it's already being used. What about something like:

Please update your browser or visit browsehappy.com to find a new browser.

?

#5 in reply to: ↑ 4 @SergeyBiryukov
5 years ago

Replying to kurtpayne:

What about something like:

Please update your browser or visit browsehappy.com to find a new browser.

There's already a link to browsehappy.com in "Update %s or learn how to browse happy" string.

#6 @tw2113
5 years ago

  • Cc michael.d.beckwith@… added

@tw2113
5 years ago

Added some of the suggested text to the browse happy messages

#7 @tw2113
5 years ago

  • Keywords has-patch added

#8 @nacin
4 years ago

browsehappy.com now catches XP + IE and delivers a specific warning. I'm fine with doing that for other browsers listed. Is there a need to change the text otherwise? (I don't think so.)

@MikeHansenMe
4 years ago

current message for ie 7 users

#9 @MikeHansenMe
4 years ago

  • Cc mdhansen@… added
  • Keywords close added

The current message seems to be sufficient. Proposing we close this ticket.

#10 @nacin
4 years ago

  • Milestone changed from Awaiting Review to WordPress.org
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.