WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19086 closed defect (bug) (fixed)

Admin bar drop-down arrows are incorrectly positioned (RTL)

Reported by: rosshanney Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: RTL Keywords: has-patch
Focuses: Cc:

Description

The little downward pointing arrow thingies that appear in the admin bar when hovering over an item that has a drop-down menu are not positioned correctly when in RTL mode. Please see the attached screenshot.

The attached patch also adjusts the CSS selection rule slightly (for both LTR and RTL), so that it only targets admin bar items that have the .menupop class (i.e. those with drop-down menus). Without this change, the little downward pointing arrow appears on the 'Updates' menu item, despite it not having a drop-down menu (this occurs in LTR mode too, but the arrow is hidden by the white update count circle).

Attachments (3)

admin-bar-arrows-1.png (3.7 KB) - added by rosshanney 2 years ago.
19086.diff (1.1 KB) - added by rosshanney 2 years ago.
19086.patch (572 bytes) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (8)

rosshanney2 years ago

comment:1 rosshanney2 years ago

  • Keywords has-patch added

comment:2 ocean902 years ago

  • Milestone changed from Awaiting Review to 3.3

comment:3 follow-up: azaozz2 years ago

Patch looks good but not sure if we are keeping these arrows. They were meant to show on hover when the menus needed clicks to open/drop down.

SergeyBiryukov2 years ago

comment:4 in reply to: ↑ 3 SergeyBiryukov2 years ago

Replying to azaozz:

not sure if we are keeping these arrows. They were meant to show on hover when the menus needed clicks to open/drop down.

19086.patch removes the arrows.

comment:5 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19152]:

Remove drop-down arrows from admin bar, props SergeyBiryukov, fixes #19086

Note: See TracTickets for help on using tickets.