Write strings in numbered argument conversion specifications form for better understanding

[jiehanzheng]

Strings should be written in numbered argument conversion specifications from so that they can be translated into other languages like Chinese without sounding weird.

For example, we've got this string here ​http://core.trac.wordpress.org/browser/trunk/wp-admin/user-new.php#L75

$message = __("Hi,\n\nYou have been invited to join '%s' at\n%s with the role of %s.\nPlease click the following link to confirm the invite:\n%s\n");

The placeholders are all unnumbered, so I am unable to rearrange the arguments to make them sound better. Chinese translation requires get_option('blogname') to be the first, $_REQUEST[ 'role' ] as the second, then site_url(), and site_url("/newbloguser/$newuser_key/") as the last, which cannot be fulfilled with the current string.

[SergeyBiryukov]

19090.patch​ makes the string more consistent with the one in admin_created_user_email():
​http://core.trac.wordpress.org/browser/trunk/wp-admin/user-new.php#L22

[duck_]

Surely the translation can just specify the placeholder/argument ordering as part of the translated string itself without the original string having to change?

If there's some reason this cannot be done I would've thought that most strings should specify ordering and that there would be a lot more instances of troublesome strings than just this one.

[jiehanzheng]

Replying to duck_:

Surely the translation can just specify the placeholder/argument ordering as part of the translated string itself without the original string having to change?

If there's some reason this cannot be done I would've thought that most strings should specify ordering and that there would be a lot more instances of troublesome strings than just this one.

It's a very reasonable point which I didn't think of... :(

I am changing the ticket properties now.

[westi]

Replying to duck_:

Surely the translation can just specify the placeholder/argument ordering as part of the translated string itself without the original string having to change?

If there's some reason this cannot be done I would've thought that most strings should specify ordering and that there would be a lot more instances of troublesome strings than just this one.

We should make it as easy as possible for translators to do the translations. Part of this is using numbered placeholders where appropriate so as to make the translation process faster.

[zeo]

Almost related to [15522].

Also the patch above is missing translators notes/comments

[SergeyBiryukov]

Replying to zeo:

Also the patch above is missing translators notes/comments

Thanks, added comments in 19090.2.patch​.

[ryan]

In [19255]:

Used numbered format specifiers. Add translator note. Props SergeyBiryukov. fixes #19090