Admin menu flyouts are one pixel off when collapsed

[olleicua]

In Revision #19118 admin menu flyouts are 1 pixel too low when the menu is collapsed. See attachment. This is consistent in Firefox, Safari, and Chrome.

[olleicua]

Fixed, looks much better. Doesn't break non-collapsed view.

[SergeyBiryukov]

Probably would be better to decrease margin-top (19119.2.patch​).

[trepmal]

fixes offset on current menu item and menu item below it

[olleicua]

2 ruins the current sub-menu. 3 looks perfect.

[helenyhou]

​19119.diff is the middle ground between SergeyBiryukov and trepmal's patches.

[trepmal]

That causes a pixel offset on the flyout below the current item

[helenyhou]

Replying to trepmal:

Ah true. Missed that case.

[olleicua]

I'm pretty sure 19119.3.patch is correct.

[nacin]

Fixed in [19277]?

[trepmal]

Not quite, pixel offset on current item's flyout and flyout of item directly below the current item (see screenshot above) still present in r19277 (and r19278)

[koopersmith]

In [19279]:

Fix folded flyout overlaps for current items. props trepmal. fixes #19119.

[trepmal]

Seems my selector was a bit too specific - if the current item doesn't have a submenu, the pixel offset still happens with the flyout below.

Also, hoverstate on the current item with no submenu isn't right. Following the unfolded style, it shouldn't change on hover .

Probably not necessary, but here's a short (8s) screencast that shows both quirks
​http://screencast.com/t/VeGYxhwyPk2

[trepmal]

should fix both issues I just mentioned

[olleicua]

Was [19119/wp-admin.dev.css.diff] intended to be applied on top of your other patch because if not then it doesn't seem to be fixing the problem for me:

[trepmal]

Hmm.... Just double-checked the patch and it worked for me.

To be sure, I deleted my wp-admin(.dev).css files, svn up'd and applied the patch.

[olleicua]

For some reason I am seeing this bug in FF7 in all four of the following circumstances:

• right after svn up'ing, no patches

• right after svn up'ing and applying just patch 3

• right after svn up'ing and applying just wp-admin.dev.css.diff

• right after svn up'ing and applying patch 3 then wp-admin.dev.css.diff

not sure what's going on here..

[olleicua]

Figured it out. I had reduced the font size in my browser. When I restored it to the normal size everything worked as expected. Not sure how many people actually change their font size in FF frequently while trying to use the WP admin but it seems to severely break the admin bar in other ways too. Anyway not the point of this ticket so pretend I said nothing.

[ocean90]

trepmal, is it still an issue?

[trepmal]

Partially fixed, the pixel offset seems to be fixed. But the hoverstate problem is still there

Also, hoverstate on the current item with no submenu isn't right. Following the unfolded style, it shouldn't change on hover .

If comments (a menu item without submenu items) is the current item, the arrow is visible but disappears on mouseover.

If needed, I can create a new ticket for this since it's not part of the original issue reported here.

[ocean90]

trepmal, that is correct behavior.

We had a long discussion on this in IRC, see
​https://irclogs.wordpress.org/chanlog.php?channel=wordpress-dev&day=2011-11-08&sort=asc#m329457

[trepmal]

Okay, it just doesn't give the impression of being intentional to me. Especially since in the unfolded menu there is no change on mouseover.

[trepmal]

comment:18 addressed in [19433]