WordPress.org
Get WordPress

Make WordPress Core

Opened 13 years ago

Closed 13 years ago

#19126 closed defect (bug) (fixed)

No separator between Search and custom items in Admin Bar

Reported by: markjaquith's profile markjaquith Owned by: koopersmith's profile koopersmith
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: needs-patch
Focuses: Cc:

Description (last modified by markjaquith)

http://stage.f.cl.ly/items/2x112S1t011l0Y1s2x3t/Screen%20Shot%202011-11-02%20at%2011.59.38%20PM.png

We should use CSS :last-child to omit the separator after the last item, whether built-in or custom.

Attachments (3)

admin-menu-test.php​ (250 bytes) - added by markjaquith 13 years ago.
Admin Bar test plugin
19126.diff​ (509 bytes) - added by markjaquith 13 years ago.
19126.remove.patch​ (419 bytes) - added by ocean90 13 years ago.

Download all attachments as: .zip

Change History (14)

@markjaquith
13 years ago

Admin Bar test plugin

@markjaquith
13 years ago

#1 @markjaquith
13 years ago

  • Description modified (diff)
  • Keywords has-patch added
  • Owner set to markjaquith
  • Status changed from new to accepted

Patch to use CSS :last-child to hide the right border. Use admin-menu-test.php (drop in mu-plugins) to test.

#2 @nacin
13 years ago

  • Keywords commit added

Looks good. Won't work in IE8. Not losing sleep.

#3 @nacin
13 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19168]:

Hide right border on final admin bar menu item with :last-child, rather than assuming it is search. props markjaquith, fixes #19126.

#4 @nacin
13 years ago

In [19169]:

Give selectors their own lines. see #19126.

@ocean90
13 years ago

#5 @ocean90
13 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

19126.remove.patch​

#6 @nacin
13 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19183]:

Remove commented out code. props ocean90, fixes #19126.

#7 @linuxologos
13 years ago

  • Keywords needs-patch added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

After [19230] :last-child applies to #wp-admin-bar-my-account (new ul.top-secondary), so right-border is displayed for final "primary" admin bar menu item.

#8 @nacin
13 years ago

  • Owner changed from markjaquith to koopersmith
  • Status changed from reopened to assigned

#9 @ryan
13 years ago

  • Component changed from UI to Admin Bar

#10 @linuxologos
13 years ago

Seems to be fixed again, after [19261].

#11 @ryan
13 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.