WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19139 closed defect (bug) (fixed)

"View Site" and other items below site/admin title need to grow

Reported by: nacin Owned by: koopersmith
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description (last modified by nacin)

See curious appearance in 18197#comment:108.

Attachments (1)

admin-bar-submenu-width.diff (334 bytes) - added by jakemgold 2 years ago.
Sets min-width to 100% on submenus in admin bar

Download all attachments as: .zip

Change History (17)

comment:1 nacin2 years ago

  • Description modified (diff)

comment:2 jakemgold2 years ago

  • Owner set to jakemgold
  • Status changed from new to accepted

comment:3 jakemgold2 years ago

Setting min-width to 100% on the submenu UL appears to fix this... tested in Chrome 15, Firefox 7, and IE7, IE8, IE9 with good results.

Patch following this comment...

jakemgold2 years ago

Sets min-width to 100% on submenus in admin bar

comment:4 jakemgold2 years ago

  • Keywords has-patch added

comment:5 nacin2 years ago

It would be nice if "Visit Site" can shrink as well (if it's an only child), that way it doesn't look as weird. see #19139.

Version 0, edited 2 years ago by nacin (next)

comment:6 nacin2 years ago

Sorry, I meant, see #19184.

comment:7 ryan2 years ago

  • Component changed from UI to Admin Bar

comment:8 nacin2 years ago

  • Owner changed from jakemgold to koopersmith
  • Status changed from accepted to assigned

koop for review.

comment:9 koopersmith2 years ago

  • Status changed from assigned to accepted

This patch doesn't play nicely with top-level secondary menus — .quicklinks ul targets all menus, not just submenus.

It should be easily fixed, though. Looking into it now.

comment:10 ryan2 years ago

  • Version set to 3.3

comment:11 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

Don't see this any more, seems fixed in the meantime.

comment:12 ryan2 years ago

  • Milestone changed from 3.3 to Future Release
  • Resolution fixed deleted
  • Status changed from closed to reopened

Still exists if you have a long title. We can live with it for 3.3. Reopening and punting to future.

comment:13 duck_2 years ago

Closed #19491 as dupe. Has alternative patch.

comment:14 camiloclc2 years ago

What about just setting min-width on a direct child selector? Like ".ab-top-menu > .menupop > .ab-sub-wrapper"?

comment:15 koopersmith2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19717]:

Allow toolbar submenus to expand to the width of the parent item. Props camiloclc, fixes #19139.

comment:16 SergeyBiryukov2 years ago

  • Milestone changed from Future Release to 3.4
Note: See TracTickets for help on using tickets.