WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19143 closed defect (bug) (fixed)

RTL margin fix for About screens

Reported by: SergeyBiryukov Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: RTL Keywords: has-patch
Focuses: Cc:

Description

[19143] misses margin-right: 0 for RTL styles.

Attachments (3)

19143.rtl-margin-fix-and-cleanup.patch (3.0 KB) - added by SergeyBiryukov 2 years ago.
19143.rtl-margin-fix-only.patch (475 bytes) - added by SergeyBiryukov 2 years ago.
19143.2.patch (1.7 KB) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 SergeyBiryukov2 years ago

  • Component changed from UI to RTL

19143.rtl-margin-fix-and-cleanup.patch moves the styles to wp-admin-rtl.dev.css with a bit of cleanup.

19143.rtl-margin-fix-only.patch just removes the excess margin.

comment:2 follow-up: nacin2 years ago

  • Summary changed from RTL margin fix for credits.php to RTL margin fix for About screens

The about screen also has some tab issues, it seems: http://cl.ly/3B1a173b1V1p0u2l1C1q

comment:3 nacin2 years ago

In [19146]:

RTL for credits. props SergeyBiryukov, see #19143.

SergeyBiryukov2 years ago

comment:4 in reply to: ↑ 2 SergeyBiryukov2 years ago

Replying to nacin:

The about screen also has some tab issues, it seems: http://cl.ly/3B1a173b1V1p0u2l1C1q

Yeah, the whole screen needs RTL adjustments. Done in 19143.2.patch.

comment:5 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19149]:

RTL adjustments for the About screens, props SergeyBiryukov, fixes #19143

Note: See TracTickets for help on using tickets.