WordPress.org
Get WordPress

Make WordPress Core

Opened 15 years ago

Closed 15 years ago

#19143 closed defect (bug) (fixed)

RTL margin fix for About screens

Reported by: SergeyBiryukov Owned by: azaozz
Priority: normal Milestone: 3.3
Component: RTL Version: 3.3
Severity: normal Keywords: has-patch
Cc: Focuses:

Description

[19143] misses margin-right: 0 for RTL styles.

Attachments (3)

19143.rtl-margin-fix-and-cleanup.patch​ (3.0 KB ) - added by SergeyBiryukov 15 years ago.
19143.rtl-margin-fix-only.patch​ (475 bytes ) - added by SergeyBiryukov 15 years ago.
19143.2.patch​ (1.7 KB ) - added by SergeyBiryukov 15 years ago.

Download all attachments as: .zip

Change History (8)

@SergeyBiryukov
15 years ago

@SergeyBiryukov
15 years ago

#1 @SergeyBiryukov
15 years ago

  • Component UI → RTL

19143.rtl-margin-fix-and-cleanup.patch​ moves the styles to wp-admin-rtl.dev.css with a bit of cleanup.

19143.rtl-margin-fix-only.patch​ just removes the excess margin.

#2 follow-up: @nacin
15 years ago

  • Summary RTL margin fix for credits.php → RTL margin fix for About screens

The about screen also has some tab issues, it seems: ​http://cl.ly/3B1a173b1V1p0u2l1C1q

#3 @nacin
15 years ago

In [19146]:

RTL for credits. props SergeyBiryukov, see #19143.

@SergeyBiryukov
15 years ago

#4 in reply to: ↑ 2 @SergeyBiryukov
15 years ago

Replying to nacin:

The about screen also has some tab issues, it seems: ​http://cl.ly/3B1a173b1V1p0u2l1C1q

Yeah, the whole screen needs RTL adjustments. Done in 19143.2.patch​.

#5 @azaozz
15 years ago

  • Owner set to azaozz
  • Resolution → fixed
  • Status new → closed

In [19149]:

RTL adjustments for the About screens, props SergeyBiryukov, fixes #19143

Note: See TracTickets for help on using tickets.