#19168 closed defect (bug) (fixed)
Change 'View Comment' button on comment.php?action=editcomment
| Reported by: | ocean90 | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.4 |
| Component: | Comments | Version: | 3.3 |
| Severity: | normal | Keywords: | has-patch needs-screenshots |
| Cc: | Focuses: | ui |
Description
To be consistent with other screens the object should be removed.
Or Jane's words:
that really ought to get moved out of the box altogether, but that's too big to be doing this late in cycle
Attachments (4)
Change History (18)
#3
@
14 years ago
Hmm... I think I actually prefer the more descriptive "View comment" than just "View". Especially since we've got the space.
Can you talk me through why you like "View" better?
#4
@
14 years ago
Hey, the ticket is 8 months old, but I think it was a reaction on a comment by Jane on IRC. :)
#5
follow-up:
↓ 8
@
14 years ago
View and Preview are fundamentally different things, and View links/buttons have a different place in the UI than Preview.
#8
in reply to: ↑ 5
@
11 years ago
- Component Text Changes → Comments
- Keywords dev-feedback ux-feedback added; needs-refresh removed
- Milestone Future Release → 4.4
- Owner set to
- Status new → accepted
Replying to jane:
View and Preview are fundamentally different things, and View links/buttons have a different place in the UI than Preview.
... that really ought to get moved out of the box altogether
I agree. I think the Status box on edit-comment has ended up as sort of a dumping ground for all associated information for a comment. Plus the meta box name, Status, is kind of a misnomer and doesn't really follow the verb naming scheme like are used on Posts and Media for instance, which use Publish and Save, respectively.
- Unlike posts, comments have a 'View Comment'-type button, never a preview button (dissimilar concepts)
- Unlike posts, clicking Update redirects back to the comments screen so no editor messaging
- Unlike posts, comments don't have statuses or visibility settings
- Like posts, comments essentially have a permalink
- Like posts, comments have an editing screen
In 19168.2.patch I've moved the 'View Comment' button from the Status meta box to a slug box that displays the permalink just like we do for posts and media. See comment_permalink.png for what a first run of this might look like.
There's a lot more work we could do on this page, but I think this is a pretty good start in unifying the experiences a little bit.
This ticket was mentioned in Slack in #core by sergey. View the logs.
11 years ago
#10
@
11 years ago
- Keywords needs-patch added; has-patch dev-feedback ux-feedback removed
I dislike that a "button" is really a link, even if it matches Edit Post. Since the permalink isn't editable, seems like that should just be a link (the way we want it to be on Edit Post as well someday, see #18306). We could possibly even work on that now as well to make them match.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Hey ocean90,
I think I'm missing something here. Can you please provide some more details.
It sounds to me like you are proposing removing the "View comment" button in the right-hand "Status" box of comment.php?action=editcomment. Is that right?
It seems to me that that button is consistent with the edit posts page which has a "Preview changes" button.