Make WordPress Core

Opened 14 years ago

Closed 11 years ago

Last modified 11 years ago

#19168 closed defect (bug) (fixed)

Change 'View Comment' button on comment.php?action=editcomment

Reported by: ocean90's profile ocean90 Owned by: wonderboymusic's profile wonderboymusic
Milestone: 4.4 Priority: normal
Severity: normal Version: 3.3
Component: Comments Keywords: has-patch needs-screenshots
Focuses: ui Cc:

Description

To be consistent with other screens the object should be removed.

Or Jane's words:

that really ought to get moved out of the box altogether, but that's too big to be doing this late in cycle

Attachments (4)

19168.patch (563 bytes) - added by ocean90 14 years ago.
19168.2.patch (1.2 KB) - added by DrewAPicture 11 years ago.
Permalink
comment_permalink.png (76.3 KB) - added by DrewAPicture 11 years ago.
19168.diff (2.1 KB) - added by wonderboymusic 11 years ago.

Download all attachments as: .zip

Change History (18)

#1 @lessbloat
14 years ago

Hey ocean90,

I think I'm missing something here. Can you please provide some more details.

It sounds to me like you are proposing removing the "View comment" button in the right-hand "Status" box of comment.php?action=editcomment. Is that right?

It seems to me that that button is consistent with the edit posts page which has a "Preview changes" button.

@ocean90
14 years ago

#2 @ocean90
14 years ago

No, I mean to remove the word "Comment", see patch.

#3 @lessbloat
14 years ago

Hmm... I think I actually prefer the more descriptive "View comment" than just "View". Especially since we've got the space.

Can you talk me through why you like "View" better?

#4 @ocean90
14 years ago

Hey, the ticket is 8 months old, but I think it was a reaction on a comment by Jane on IRC. :)

#5 follow-up: @jane
14 years ago

View and Preview are fundamentally different things, and View links/buttons have a different place in the UI than Preview.

#6 @sabreuse
13 years ago

  • Component changed from UI to Text Changes
  • Keywords ui-focus added; ui-feedback removed

#7 @chriscct7
11 years ago

  • Keywords has-patch needs-refresh added; needs-patch removed

@DrewAPicture
11 years ago

Permalink

#8 in reply to: ↑ 5 @DrewAPicture
11 years ago

  • Component changed from Text Changes to Comments
  • Keywords dev-feedback ux-feedback added; needs-refresh removed
  • Milestone changed from Future Release to 4.4
  • Owner set to DrewAPicture
  • Status changed from new to accepted

Replying to jane:

View and Preview are fundamentally different things, and View links/buttons have a different place in the UI than Preview.

... that really ought to get moved out of the box altogether

I agree. I think the Status box on edit-comment has ended up as sort of a dumping ground for all associated information for a comment. Plus the meta box name, Status, is kind of a misnomer and doesn't really follow the verb naming scheme like are used on Posts and Media for instance, which use Publish and Save, respectively.

  • Unlike posts, comments have a 'View Comment'-type button, never a preview button (dissimilar concepts)
  • Unlike posts, clicking Update redirects back to the comments screen so no editor messaging
  • Unlike posts, comments don't have statuses or visibility settings
  • Like posts, comments essentially have a permalink
  • Like posts, comments have an editing screen

In 19168.2.patch I've moved the 'View Comment' button from the Status meta box to a slug box that displays the permalink just like we do for posts and media. See comment_permalink.png for what a first run of this might look like.

There's a lot more work we could do on this page, but I think this is a pretty good start in unifying the experiences a little bit.

This ticket was mentioned in Slack in #core by sergey. View the logs.


11 years ago

#10 @helen
11 years ago

  • Keywords needs-patch added; has-patch dev-feedback ux-feedback removed

I dislike that a "button" is really a link, even if it matches Edit Post. Since the permalink isn't editable, seems like that should just be a link (the way we want it to be on Edit Post as well someday, see #18306). We could possibly even work on that now as well to make them match.

#11 @wonderboymusic
11 years ago

  • Owner changed from DrewAPicture to wonderboymusic
  • Status changed from accepted to assigned

#12 @wonderboymusic
11 years ago

  • Keywords has-patch added; needs-patch removed

#13 @wonderboymusic
11 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 34072:

Edit Comment screen: remove the "View Comment" button (actually a link) from the publish meta box. Mimic the "Edit URL/Permalink" UI from the Edit Post screen to show the comment link below the screen title, but make it an actual link, not a button.

Props ocean90, DrewAPicture, wonderboymusic.
Fixes #19168.

#14 @ryan
11 years ago

  • Keywords needs-screenshots added
Note: See TracTickets for help on using tickets.