#19176 closed defect (bug) (fixed)
Tag auto-suggest doesn't work in Quick Edit for posts with no tags
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.3 | Priority: | normal |
Severity: | normal | Version: | 3.0 |
Component: | Quick/Bulk Edit | Keywords: | has-patch |
Focuses: | Cc: |
Description
Try adding a tag to a post with No Tags on Posts screen through Quick Edit. The auto-suggest feature doesn't work.
Try the same with a post that already has at least one tag. Auto-suggest works fine.
This was introduced in WP 3.0 and affects WP 3.3 too.
Attachments (3)
Change History (16)
#1
@
12 years ago
- Keywords has-patch added
The current JS only binds the autosuggest if the textarea isn't empty t start with - I'm guessing this was a mistake.
#2
@
12 years ago
19176.diff works for me.
#6
@
12 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed
In [19205]:
#7
@
12 years ago
- Keywords needs-patch added; has-patch removed
- Resolution fixed deleted
- Status changed from closed to reopened
Unfortunately tags autosuggest fixed in [19204] for Quick Edit doesn't work for Bulk Edit. It broke in WP 3.0 along with Quick Edit. Fixing may be related.
#8
@
12 years ago
Not sure if there is more to this but it looks like the selector needed some updates.
#10
@
12 years ago
19716.diff seems to fix the issue as far as post_tag taxonomy is concerned. Is it simple enough to support custom (non-hierarchical) taxonomies too? Quick Edit does. Bulk Edit does not yet.
@
12 years ago
Sorry for the filename typo in my first patch. Here's round 2 with support for post_tags and all other non heirarchy taxs.
#11
@
12 years ago
Going with 19716.diff for now, as it is a straightforward fix for post tags in bulk edit.
Adding support for all flat taxonomies for all post types requires a bit more work, as evidenced by the first pass in 19176v2.diff. It would probably be better to iterate through $('.tags_input', rowData) and cherry pick the taxonomies from there. See how flat taxonomies are handled for quick edit (line ~183).
scottbasgaard, can you open a new ticket for this? We can handle it in 3.4.
Hook autouggest even if the textarea is empty to start with