WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19186 closed defect (bug) (fixed)

Admin bar sub-menu shadows bleed "up" into parent container

Reported by: jakemgold Owned by: koopersmith
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

It's subtle, and seems to vary in intensity between both browsers and Windows / OS X, probably due to different hardware acceleration / anti-aliasing handling.

On Windows, I can only see it on Firefox (tested with 7); IE9 and Chrome appear fine. A colleague can see it in Chrome and Firefox on OS X. Probably anti-aliasing differences between the OS's / browsers.

Reducing shadow strength to 3px seems to fix it for me, but not sure if the aesthetic change is desirable. It's more complex, but we could also give the parent container's anchor a white background and z-index it above the submenu UL.

Attachments (3)

admin-bar-sub-shadow.png (5.4 KB) - added by jakemgold 2 years ago.
Subtle shadow bleeding up into parent
admin-bar-submenu-shadow.diff (762 bytes) - added by jakemgold 2 years ago.
Used z-index / background color solution for a more definitive solution
admin-bar-submenu-shadow-rev2.diff (968 bytes) - added by jakemgold 2 years ago.
modifies last patch to fix W issue

Download all attachments as: .zip

Change History (10)

jakemgold2 years ago

Subtle shadow bleeding up into parent

jakemgold2 years ago

Used z-index / background color solution for a more definitive solution

comment:1 jakemgold2 years ago

  • Owner set to jakemgold
  • Status changed from new to accepted

comment:2 jakemgold2 years ago

  • Keywords has-patch added

comment:3 helenyhou2 years ago

  • Milestone changed from Awaiting Review to 3.3

Seems to cause an issue with the W menu when mouse is over the submenu: http://cl.ly/0J432c2H3C0h3o152r1f

comment:4 ryan2 years ago

  • Component changed from General to Admin Bar

comment:5 jakemgold2 years ago

Forthcoming revised patch only applies new style to anchor, not inner span, address the W issue Helen caught.

jakemgold2 years ago

modifies last patch to fix W issue

comment:6 koopersmith2 years ago

  • Owner changed from jakemgold to koopersmith

I'll review the patch and guide the fix into core.

comment:7 koopersmith2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19403]:

Tighten admin bar submenu shadows. fixes #19186.

Note: See TracTickets for help on using tickets.