WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19194 closed defect (bug) (fixed)

Fullscreen button in HTML mode is missing

Reported by: Ipstenu Owned by: azaozz
Milestone: 3.3 Priority: high
Severity: critical Version: 3.3
Component: Editor Keywords:
Focuses: Cc:

Description

WordPress 3.3-beta2-19181. The Fullscreen button for HTML mode in the post editor is missing. You can still get there by switching to visual, going full screen, and then back to HTML, but that's a really bad idea.

Change History (6)

comment:1 SergeyBiryukov2 years ago

  • Milestone changed from Awaiting Review to 3.3

comment:2 follow-up: nacin2 years ago

  • Severity changed from normal to critical

Probably broken by [19172]?

comment:3 in reply to: ↑ 2 ; follow-up: duck_2 years ago

Replying to nacin:

Probably broken by [19172]?

Yes.

buttons['fullscreen'] = new qt.FullscreenButton();

went missing from quicktags.js.

Also does _buttonsInit need to loop through theButtons right after looping through edButtons to build html string? Can't that be done whilst adding elements from edButtons to theButtons in the first loop?

comment:4 ryan2 years ago

  • Priority changed from normal to high

comment:5 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19215]:

Bring back the Fullscreen button in Quicktags, fixes #19194

comment:6 in reply to: ↑ 3 azaozz2 years ago

Replying to duck_:

The second loop was supposed to happen after theButtons were filtered but since we don't have proper filters in JS (yet), we can do that later.

Note: See TracTickets for help on using tickets.