Context Navigation

← Previous Ticket
Next Ticket →

#19205 closed defect (bug) (fixed)

Orphaned categories can be created by accident

Reported by:	dzver	Owned by:	wonderboymusic
Priority:	normal	Milestone:	4.0
Component:	Taxonomy	Version:
Severity:	minor	Keywords:	has-patch needs-unit-tests
Cc:		Focuses:

Description

There are two ways to do that.

You can work on category tree from two browser windows.

In window one, delete a category
In window two, add a child to the category that has been deleted.

wp_insert_term needs to check if the parent exists.

If you delete a couple of categories with bulk-delete, a third level child node can become orphan.

wp_delete_term uses get_term to find the parent node and can retrieve cached data.

Attachments (1)

19205.diff (625 bytes ) - added by dlh 13 years ago.

Download all attachments as: .zip

Change History (6)

#1 @solarissmoke
15 years ago

Related: #8119

@dlh
13 years ago

Attachment 19205.diff added

#2 @dlh
13 years ago

Keywords has-patch added

Diff attempts to address issue (1). After the $args are parsed, checks term_exists() if needed.

#3 @wonderboymusic
12 years ago

Keywords needs-unit-tests added
Milestone Awaiting Review → 4.0

We should inspect this with unit tests

#4 @wonderboymusic
12 years ago

Owner set to wonderboymusic
Resolution → fixed
Status new → closed

In 29196:

Avoid a race condition when multiple windows are open so that orphaned terms cannot be created by accident.

Adds a unit test.

Props dlh.
Fixes #19205.

#5 @SergeyBiryukov
12 years ago

In 29234:

Use an existing string.

see #19205.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#19205 closed defect (bug) (fixed)

Orphaned categories can be created by accident

Description

Attachments (1)

Change History (6)

#1 @solarissmoke 15 years ago

@dlh 13 years ago

#2 @dlh 13 years ago

#3 @wonderboymusic 12 years ago

#4 @wonderboymusic 12 years ago

#5 @SergeyBiryukov 12 years ago