Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#19221 closed defect (bug) (fixed)

My Sites menu has invalid markup

Reported by: wpmuguru Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Multisite Keywords: has-patch
Focuses: Cc:


The My Sites menu currently has a <ul> within a <ul> and no intervening <li> when the user is a super admin.

Attachments (2)

19221.diff (433 bytes) - added by wpmuguru 3 years ago.
19221.2.diff (472 bytes) - added by wpmuguru 3 years ago.
ignore 19221.diff

Download all attachments as: .zip

Change History (7)

@wpmuguru3 years ago

@wpmuguru3 years ago

ignore 19221.diff

comment:1 @wpmuguru3 years ago

The first patch fixed the issue for super admins but created an issue with non-super admins.

comment:2 @nacin3 years ago

Looks like 19221.2.diff has a logic inversion — we want sites to be secondary if there is a "Network Admin" menu, so secondary => true should be for super admins.

That said, [19230] forgot to force secondary items to primary items when there are no primary items. I'm going to commit a change for that as well.

comment:3 @nacin3 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19235]:

Show sites in the 'My Sites' menu as secondary items only when the user is a super admin and therefore has a primary menu item (Network Admin). props wpmuguru, fixes #19221.

comment:4 @nacin3 years ago

In [19236]:

Promote secondary admin bar items to primary if there are no primary items at time of render. see #19136, #19221.

comment:5 @SergeyBiryukov3 years ago

  • Milestone changed from Awaiting Review to 3.3
Note: See TracTickets for help on using tickets.