WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19228 closed defect (bug) (fixed)

Big files upload problems in IE and Opera using Plupload

Reported by: azaozz Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Upload Keywords: ux-feedback
Focuses: Cc:

Description (last modified by azaozz)

Been testing this for a while and there doesn't seem to be a fix or a workaround for files > 200MB - 300MB. Also there is a "big file" conflict in Firefox (tested with both 7 & 8) when Firebug is installed and active. Closing Firebug allows upload of files > 1GB.

Change History (27)

comment:1 azaozz2 years ago

At this point it seems we will need to show a warning in IE and Opera when the PHP upload limit is above 200MB and offer to switch to the old style (HTML 4) uploader for bigger files. Any other suggestions are welcome.

comment:2 azaozz2 years ago

  • Description modified (diff)

comment:3 follow-up: ocean902 years ago

Flash runtime seems like it doesn't work with a 600MB file, Silverlight returns at 88% an IO error. Tested in Chrome and Firefox.

comment:4 azaozz2 years ago

In [19257]:

Bring back the multi-file/html uploader switching, see #19228

comment:5 nacin2 years ago

In [19260]:

Normal sentence case. see #19228.

comment:6 azaozz2 years ago

  • Summary changed from BIg files upload problems in IE and Opera using Plupload to Big files upload problems in IE and Opera using Plupload

comment:7 in reply to: ↑ 3 azaozz2 years ago

Replying to ocean90:

By default we use HTML 5 runtime which loads in FF, Chrome and Safari (also IE10 should have support for it). Didn't have problems uploading large files in FF 8, Chrome (latest) and Safari 5 on Mac (Safari on win has a bug that would probably be fixed in the next release).

comment:8 azaozz2 years ago

  • Keywords ux-feedback added

Following up on [19257] we can add another message in IE and Opera when the server supports uploading of larger files, or perhaps we can add some text in the Help for Media -> Add new screen.

It is also possible to detect when a large file is queued and the upload fails (file doesn't start uploading, no error thrown). So we could display a message/error text instead of the progress bar.

Last edited 2 years ago by azaozz (previous) (diff)

comment:9 follow-up: jane2 years ago

Would the error/message text in place of progress bar give option to switch to html uploader? Want to make sure we provide a way to succeed in addition to the message of failure.

comment:10 in reply to: ↑ 9 azaozz2 years ago

Replying to jane:

Yes we can add a link that would toggle the uploader to HTML4 mode (similar to the "Try the browser uploader instead" above). I'll put that in today.

comment:11 azaozz2 years ago

In [19266]:

Add error message when a big file fails to upload, expose the XHR request in plipload and abort() it, see #19228

comment:12 azaozz2 years ago

In [19268]:

Media Lib: fix displaying file headers in IE7, delegate the Show/Hide JS, prevent displaying upload error for the same file twice, see #19228

comment:13 azaozz2 years ago

Would it be good to show a warning message in IE and Opera that bigger files need to be uploaded with the browser uploader? Can make that conditional on max size allowed for the server so it wouldn't show when server doesn't allow 100MB+ uploads.

comment:14 chexee2 years ago

@azaozz - A warning message makes sense. Making the limitation as transparent as possible before the user puts some work/time into uploading is always a plus. Maybe place it near the file size limit message?

comment:15 azaozz2 years ago

@chexee yes, was thinking the same. Can be something like:

"This browser has some limitations when uploading large files with the multi-file uploader, for best results please use the browser uploader."

Can probably mention that Chrome and FF don't have the limitation.

comment:16 chexee2 years ago

Might make sense to be a little more forceful with language. Not-best-results means it will fail. Something like:

"Your browser has some limitations uploading large files with the multi-file uploader. You should use the browser uploader for files over 100MB."

Since the message will be conditional (will only show up in Opera/IE), maybe we should leave the technical details out in favor of simplicity.

comment:17 follow-up: azaozz2 years ago

In [19286]:

Add big-file-upload-warning for IE and Opera, left-align the percentage in the progress bar, see #19228

comment:18 in reply to: ↑ 17 ; follow-up: chexee2 years ago

Replying to azaozz:

In [19286]:

Add big-file-upload-warning for IE and Opera, left-align the percentage in the progress bar, see #19228

The message looks good, but it doesn't appear to stop the file from actually trying to upload. It froze my browser, then said the upload was complete.

Screenshot: http://chx.mx//96/a9ffwjwmoswko.png

A long filename also makes the warning run into the Dismiss link and look like its one line. Can we add more spacing between "Dismiss" and the warning?

Screenshot: http://chx.mx//85/j9rasg2ds8448.png

comment:19 in reply to: ↑ 18 ; follow-up: azaozz2 years ago

Replying to chexee:

The message looks good, but it doesn't appear to stop the file from actually trying to upload.

It's a warning. We can enforce it too if needed, can set max upload limit to 100MB regardless of the allowed file size by the server. That will throw an error when trying to upload larger files.

A long filename also makes the warning run into the Dismiss link and look like its one line. Can we add more spacing between "Dismiss" and the warning?

Sure, would 15px be good? (Line 3780 in wp-admin.css).

comment:20 azaozz2 years ago

In [19294]:

Add some more padding to the Dismiss link in the uploader notices, see #19228

comment:21 in reply to: ↑ 19 chexee2 years ago

Replying to azaozz:

It's a warning. We can enforce it too if needed, can set max upload limit to 100MB regardless of the allowed file size by the server. That will throw an error when trying to upload larger files.

Ah, that makes sense.

A long filename also makes the warning run into the Dismiss link and look like its one line. Can we add more spacing between "Dismiss" and the warning?

Sure, would 15px be good? (Line 3780 in wp-admin.css).

The last commit looks great!

comment:22 chexee2 years ago

@azaozz:
Are we planning to address the Firefox bug you mentioned in this ticket?

comment:23 azaozz2 years ago

Firefox 7 & 8 seem to work well except when Firebug is open. In these cases the error will show after 10 sec. suggesting to use the "browser uploader".

comment:24 azaozz2 years ago

BTW still trying to find more decent workaround for IE and Opera, Plupload has HTML4 mode/runtime, testing if we can switch to it automatically for big files. Of course that doesn't support multi-file queue or progress bar, but will upload the file properly.

comment:25 ocean902 years ago

Related: #19276

comment:26 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19329]:

When queueing too large files in the multi-file uploader in IE or Opera, show error message and remove the file from the queue, fixes #19228

comment:27 azaozz2 years ago

In [19346]:

Uploader: show the progress bars as soon as files are queued, attempt to make the progress bar more precise, see #19228

Note: See TracTickets for help on using tickets.