WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#19242 closed defect (bug) (fixed)

Align the pixels on post.php

Reported by: nacin Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: UI Keywords:
Focuses: Cc:

Description

On post.php, there are a number of things down the left and right sides of the post body that can line up better:

  • The title text and placeholder label
  • "Permalink:"
  • "Upload/Insert"
  • Buttons in both HTML and Visual
  • Content in both HTML and Visual
  • Visual editor's "Path"
  • Word count

The best baseline is to move the publish box underneath the editor. You'll find that all of these elements use a 10px baseline.

Additionally, vertical alignment can be looked at for the height of the visual editor button row (no kitchen sink) versus the HTML editor button row (which is 1px taller), and "Upload/Insert" versus the text in the HTML/Visual tags.

RTL also needs some tweaks, particularly related to path, word count, and resizing indicator.

Following commit addresses these things. Note that sometimes the pixels will not add up to 10, as illusory distortions need to be taken into account.

Change History (4)

comment:1 nacin2 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19278]:

ALIGN ALL THE THINGS. fixes #19242.

comment:3 follow-up: johnbillion22 months ago

Was r19278 subsequently reverted? I'm not seeing these alignment tweaks in trunk and I've just decided that the 1px difference in height when switching between the Visual and HTML editors annoys me.

comment:4 in reply to: ↑ 3 nacin22 months ago

Replying to johnbillion:

Was r19278 subsequently reverted? I'm not seeing these alignment tweaks in trunk and I've just decided that the 1px difference in height when switching between the Visual and HTML editors annoys me.

No, it wasn't reverted, but this ticket was about vertical alignment, not horizontal alignment. You are looking for #18820.

Note: See TracTickets for help on using tickets.