WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#19245 closed defect (bug) (fixed)

Maintain back-compat for admin bar 'appearance'

Reported by: nacin Owned by: nacin
Milestone: 3.3 Priority: normal
Severity: normal Version:
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

We removed the 'appearance' menu in 3.3. It's fair to say that other plugins may have added nodes there.

What I think we should do is not only offer a parent translation, but to also keep the existing items under appearance. It feels cleaner overall, and reduces the risk of clashing with plugin modifications. Thoughts?

Attachments (1)

19245.diff (2.8 KB) - added by nacin 9 years ago.

Download all attachments as: .zip

Change History (10)

@nacin
9 years ago

#1 @nacin
9 years ago

  • Keywords has-patch added

#2 @ryan
9 years ago

On the other hand, plugins can continue adding to the old id for < 3.3 compat and use the new one for 3.3+ compat and everything will be nicely targeted. I think admin bar menu back compat can be much more relaxed than we are with the admin menus.

#3 @jane
9 years ago

I'll side with Ryan.

#4 @nacin
9 years ago

Agreed.

#5 @nacin
9 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In [19365]:

Handle 'appearance' as a admin bar menu parent in a backwards compatible way. fixes #19245.

#6 @nacin
9 years ago

Now I remember why I considered making 'appearance' canonical. If we ever want to incorporate the entire admin menu, we can simply scrap the appearance items all together and render it automatically. Now, we may have additional submenu items added by plugins floating next to the top-level items.

#7 @nacin
9 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Now that we have groups, we can have an 'appearance' group.

#8 @nacin
9 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19434]:

Use an 'appearance' group in the admin bar. fixes #19245.

#9 @nacin
9 years ago

The mapping code was revived in #19426.

Note: See TracTickets for help on using tickets.