WordPress.org

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 8 years ago

#19249 closed defect (bug) (fixed)

Fixing Walker Notice regarding parameter in class hierarchy.

Reported by: Blackskyliner Owned by: ryan
Milestone: 3.4 Priority: normal
Severity: normal Version: 3.2.1
Component: General Keywords: has-patch needs-testing 3.4-early
Focuses: Cc:

Description

First: Its just a "cosmetic" and PHP5 coding standard patch (or at least you could say, we want to use the PHP5 language the right way).

As I started to write a plugin to Integrate SF2 into Wordpress I got a Notice Error Exception from my SF2 Kernel which stated, that some classes, like the PluginList in the Administration Menu try to overload some function prototypes with a wrong parameter count...

So I just fixed this and now everything works fine, would be great to have this in the Release version, as its against the principles of function prototyping in PHP to overload smth. with the wrong Parameter count.

I just tested the Patch a little bit and found no other errors, but I don't know if I just had luck - or maybe break other plugins with this.

This error is in all versions of WP I tested till now, also I did not found any other patches regarding this problem, hopefully I did not failed to see them ;)

Attachments (1)

patch (1.9 KB) - added by Blackskyliner 10 years ago.
SVN diff patch

Download all attachments as: .zip

Change History (8)

@Blackskyliner
10 years ago

SVN diff patch

#1 @Blackskyliner
10 years ago

With SF2 I mean the Symfony2 Framework.

#3 @nacin
10 years ago

  • Keywords 3.4-early added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 3.3 to 3.2.1

Happy with 18975.diff in 3.4.

#4 @ryan
10 years ago

  • Milestone changed from Future Release to 3.4

#5 @ryan
10 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19679]:

Clear strict notices for the walkers. fixes #19249

#6 @dd32
10 years ago

In [19681]:

Revert Debug cruft from [19679], See #19249

#7 @DrewAPicture
8 years ago

In 25641:

Inline documentation improvements for Walker_Category and Walker_CategoryDropdown.

Also covers previously undocumented parameters.

See #23406, #19249.

Note: See TracTickets for help on using tickets.