WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

Last modified 6 years ago

#19254 closed defect (bug) (fixed)

Alignment of labels in "Add media" dialog

Reported by: waclawjacek Owned by: nacin
Milestone: 3.5 Priority: normal
Severity: minor Version: 3.2.1
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Please see the attached screenshot. It shows how the labels are aligned in the "From URL" tab (and not on the "From my computer" tab!) in the Polish translations of the "Add media" dialog. The bug is present in WP 3.3 beta 3.

It can be fixed by switching the order of <span class="alignleft"> and <label> in that form (that is how the "From my computer" form is written, plus a <br class="clear"> tag).

I'm attaching two patches to this report. The only change in them is the aforementioned switch in all places where I found <span class="alignleft"> preceding a <label>. One of the patches has the "<br class="clear">" tag along with the switch, the other doesn't. The patches should be applied to wp-admin/includes/media.php.

Take care, WJ

Attachments (5)

patch-with-br.diff (2.4 KB) - added by waclawjacek 7 years ago.
With the <br class="clear" /> tags.
patch-without-br.diff (2.3 KB) - added by waclawjacek 7 years ago.
Without the <br class="clear" /> tags.
add-media-dialog.png (47.8 KB) - added by waclawjacek 7 years ago.
A screenshot of the bug.
19254.png (59.5 KB) - added by ocean90 6 years ago.
19254-refresh.diff (2.4 KB) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (15)

#1 follow-up: @nacin
7 years ago

Is this present in 3.2?

@waclawjacek
7 years ago

With the <br class="clear" /> tags.

@waclawjacek
7 years ago

Without the <br class="clear" /> tags.

#2 in reply to: ↑ 1 @waclawjacek
7 years ago

Replying to nacin:

Is this present in 3.2?

Yes.

#3 @nacin
7 years ago

  • Version changed from 3.3 to 3.2.1

@waclawjacek
7 years ago

A screenshot of the bug.

@ocean90
6 years ago

#4 @ocean90
6 years ago

  • Milestone changed from Awaiting Review to 3.5

Let's see how it looks with the new media workflow.

#5 @helenyhou
6 years ago

  • Keywords punt added

#6 @ocean90
6 years ago

No need to punt it, if the screen will be removed.

#7 @helenyhou
6 years ago

  • Keywords needs-refresh has-patch added

I don't think the screen can be removed - it's called directly by plugins quite often. patch-without-br.diff appears sane enough, but needs to be made from root.

#8 @DrewAPicture
6 years ago

  • Keywords needs-refresh removed

#9 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 22444:

Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254.

#10 @ocean90
6 years ago

  • Keywords punt removed
Note: See TracTickets for help on using tickets.