Alignment of labels in "Add media" dialog

[waclawjacek]

Please see the attached screenshot. It shows how the labels are aligned in the "From URL" tab (and not on the "From my computer" tab!) in the Polish translations of the "Add media" dialog. The bug is present in WP 3.3 beta 3.

It can be fixed by switching the order of <span class="alignleft"> and <label> in that form (that is how the "From my computer" form is written, plus a <br class="clear"> tag).

I'm attaching two patches to this report. The only change in them is the aforementioned switch in all places where I found <span class="alignleft"> preceding a <label>. One of the patches has the "<br class="clear">" tag along with the switch, the other doesn't. The patches should be applied to wp-admin/includes/media.php.

Take care,
WJ

[nacin]

Is this present in 3.2?

[waclawjacek]

With the <br class="clear" /> tags.

[waclawjacek]

Without the <br class="clear" /> tags.

[waclawjacek]

Replying to nacin:

Is this present in 3.2?

Yes.

[waclawjacek]

A screenshot of the bug.

[ocean90]

Let's see how it looks with the new media workflow.

[ocean90]

No need to punt it, if the screen will be removed.

[helenyhou]

I don't think the screen can be removed - it's called directly by plugins quite often. patch-without-br.diff​ appears sane enough, but needs to be made from root.

[nacin]

In 22444:

Put the label outside the span to ensure margins when the text wraps. props waclawjacek. fixes #19254.