WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19271 closed defect (bug) (fixed)

Change "Close" on New Install Dashboard Welcome Area

Reported by: jane Owned by: georgestephanis
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: UI Keywords: needs-patch
Focuses: Cc:

Description

"Close" is a tab a la Screen Options and Help for some reason, instead of being a "x Dismiss" link like in pointers. This is deceptive/confusing since closing this area does not function like the slide down tabs that use that UI element. Let's switch it over to a text Dismiss with the preceding "x" we use on pointers and in Bulk Edit.

Attachments (7)

19271.diff (1.8 KB) - added by georgestephanis 2 years ago.
19271.2.diff (2.2 KB) - added by georgestephanis 2 years ago.
19271.notextshadow.diff (2.4 KB) - added by georgestephanis 2 years ago.
Version with text-shadow turned off for 'Dismiss' link.
19271.3.larger-with-margin.patch (2.5 KB) - added by chexee 2 years ago.
Adds margin and makes font-size 13px
Screen Shot 2011-11-17 at 12.38.11 PM.png (85.9 KB) - added by chexee 2 years ago.
screenshot of 19271.4 patch
19271.4-rtl.patch (432 bytes) - added by chexee 2 years ago.
Updates RTL with new bullet alignment
19271.rtl-fixes.patch (1007 bytes) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 georgestephanis2 years ago

  • Owner set to georgestephanis
  • Status changed from new to accepted

On it.

georgestephanis2 years ago

comment:2 georgestephanis2 years ago

  • Keywords has-patch added; needs-patch removed

georgestephanis2 years ago

comment:3 georgestephanis2 years ago

Uploading new patch with necessitated change for blue theme as well.

comment:4 helenyhou2 years ago

Seems to me you could take out the text shadow too. It looks weird, and inconsistent with the pointer.

georgestephanis2 years ago

Version with text-shadow turned off for 'Dismiss' link.

chexee2 years ago

Adds margin and makes font-size 13px

chexee2 years ago

screenshot of 19271.4 patch

comment:5 chexee2 years ago

Above patch also realigns bullets with paragraphs.

comment:6 ryan2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In [19326]:

Change Close tab in Welcome Screen to a Dismiss link. Aligh bullets with paragraphs. Props georgestephanis, chexee. fixes #19271

comment:7 follow-up: georgestephanis2 years ago

Chex --

margin: 1.6em 1em 1em 1.3em;

Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.

comment:8 in reply to: ↑ 7 chexee2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to georgestephanis:

Chex --

margin: 1.6em 1em 1em 1.3em;

Is the 1.3 to provide space for the :before ? Otherwise, it may need to pop into RTL as well.

its for the ULs, aligns them flush with the paragraph. and you're right. writing patch now.

chexee2 years ago

Updates RTL with new bullet alignment

comment:9 azaozz2 years ago

In [19351]:

Update RTL bullet alignment on New Install Dashboard Welcome Area, props chexee, see #19271

comment:10 ocean902 years ago

  • Keywords needs-patch added; has-patch removed

Some RTL issues:

LTR screen: http://cl.ly/BxJm

RTL screen: http://cl.ly/BzQ8

ocean902 years ago

comment:11 ocean902 years ago

19271.rtl-fixes.patch should fix the RTL issues, but it doesn't do it right. Can't find the error, maybe somebody can continue it.

Last edited 2 years ago by ocean90 (previous) (diff)

comment:12 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19356]:

RTL refresh for Welcome panel, fixes #19271

comment:13 azaozz2 years ago

In [19363]:

Improve RTL for Welcome panel, refresh css files, see #19271

Note: See TracTickets for help on using tickets.