Make WordPress Core

Opened 20 years ago

Closed 20 years ago

Last modified 19 years ago

#1930 closed defect (bug) (fixed)

upgrade code counts spam and moderated when setting comment_count column

Reported by: markjaquith's profile markjaquith Owned by: markjaquith's profile markjaquith
Milestone: Priority: normal
Severity: major Version: 1.6
Component: Administration Keywords: bg|has-patch bg|commit
Focuses: Cc:

Description

When the upgrade code iterates through the posts and sets the comment_count value, it neglects to restrict the value to approved comments ( comment_approved = '1').

Patch fixes it. Also note #1920 for a related bug (comment_count being set incorrectly when comments are submitted, which could perpetuate errors made during the upgrade).

Attachments (1)

comment_count_upgrade.diff (713 bytes) - added by markjaquith 20 years ago.
patch for WP 2.0 SVN

Download all attachments as: .zip

Change History (5)

@markjaquith
20 years ago

patch for WP 2.0 SVN

#1 @markjaquith
20 years ago

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned

#3 @ryan
20 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3192]) Count only approved comments. Props Mark JAquith. fixes #1930

#4 @(none)
19 years ago

  • Milestone 2.0 deleted

Milestone 2.0 deleted

Note: See TracTickets for help on using tickets.