WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19301 closed defect (bug) (fixed)

Superfluous positioning for .ab-top-secondary

Reported by: scribu Owned by:
Milestone: 3.3 Priority: normal
Severity: trivial Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

The user menu is floated to the right. It doesn't need the additional positioning rules.

I mark this as a defect because I have a plugin that sets the admin bar to position: absolute and it doesn't work properly now.

Attachments (2)

19301.diff (425 bytes) - added by scribu 2 years ago.
19301.2.diff (300 bytes) - added by scribu 2 years ago.

Download all attachments as: .zip

Change History (11)

scribu2 years ago

comment:1 follow-up: ocean902 years ago

This is work in progress.

The reason behind this is to make the my account for small screens available.

comment:2 ocean902 years ago

  • Cc georgestephanis added

scribu2 years ago

comment:3 in reply to: ↑ 1 ; follow-up: scribu2 years ago

Replying to ocean90:

This is work in progress.

Yes, trunk always is. :P

The reason behind this is to make the my account for small screens available.

Quite interesting. In that case we should lose the float: right.

comment:4 georgestephanis2 years ago

Actually, I set the user menu to

position:fixed;
top:0;
right:0;

(except for RTL, where it flips)

If we just left it as right:0; would it be able to scroll out of screen as expected? Which use case would that be?

And scribu -- can't you just override the CSS changes we've made in trunk in your plugin? Use a higher css specificity level, or get your stylesheet included later?

comment:5 in reply to: ↑ 3 georgestephanis2 years ago

Replying to scribu:

Replying to ocean90:

The reason behind this is to make the my account for small screens available.

Quite interesting. In that case we should lose the float: right.

The float:right ensures that the block-level-element does not occupy all the available width, but is only as wide as it needs to be. We could use display:inline-block to accomplish a similar effect, but I felt that changing fewer things would be better.

comment:6 scribu2 years ago

The float:right ensures that the block-level-element does not occupy all the available width, but is only as wide as it needs to be.

Testing in Firefox and Chrome, float: right doesn't make any difference, no matter the screen size.

comment:7 scribu2 years ago

  • Severity changed from normal to trivial

comment:8 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Had to remove the position: fixed since it covers other (plugin added?) menus.

Note: See TracTickets for help on using tickets.