wp_tiny_mce() cannot call wp_editor(), and other issues
|Reported by:||nacin||Owned by:||nacin|
|Milestone:||3.3||Priority:||highest omg bbq|
wp_tiny_mce() previously spit out the settings for the editor. Now it actually calls wp_editor() which will render the actual editor. This has broken at least three plugins (more-fields, advanced-custom-fields, wp-resume).
We need to be able to render only pieces of WP_Editor for backwards compatibility. IMO, we need to make it an absolute priority to make WP_Editor a standard object that is instantiated for each editor. The abstractions that went into it for 3.3 are backwards and will constrain us for future releases. The singleton pattern here will hurt us.
Anything that is static in terms of general initialization, rather than specific to a single instance of an editor, should be just that — static.
A bunch of functions, such as wp_fullscreen_html(), wp_link_dialog(), and wp_link_query() were deprecated and merged into WP_Editor. This makes sense if and only if these methods are going to then leverage the individual editor instances. But, I recently confirmed, all they do is render generic content. They should be marked as static class methods, or even better, reverted to become standalone functions until it makes sense to bring them into a class. (Reminds me of WP_Screen all over again.)
I am willing to work on this but no earlier than this evening/tomorrow.
Change History (29)
comment:15 follow-up: ↓ 16 @azaozz — 4 years ago
comment:19 @nacin — 4 years ago
- Owner set to nacin
- Resolution set to fixed
- Status changed from new to closed