WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19323 closed defect (bug) (fixed)

Flyout menus don't accomodate large number of submenu pages.

Reported by: ethitter Owned by: azaozz
Milestone: 3.3 Priority: low
Severity: normal Version: 3.3
Component: Administration Keywords: has-patch needs-testing
Focuses: Cc:

Description

If a large number of submenu items are added to WordPress 3.3's new flyout menus, the flyout doesn't scroll, making some items inaccessible.

The attached sample plugin adds 50 items to illustrate the problem. In practice, we (Oomph, Inc.) ran into this problem with a necessarily-large menu in a client's theme.

Attachments (3)

crazy-flyout-menus.php (873 bytes) - added by ethitter 2 years ago.
flyouts-too-tall.patch (502 bytes) - added by devinreams 2 years ago.
Don't offset the margin for really tall sub-menus (which ends up being negative) if taller than the window
slide-really-tall-sliders-up.diff (575 bytes) - added by devinreams 2 years ago.
Actually, let's slide the flyout up a bit. This way we can see it and it doesn't break the page if it has to go too low (e.g.: add options-general.php to the test plugin).

Download all attachments as: .zip

Change History (11)

ethitter2 years ago

comment:1 nacin2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 3.3
  • Priority changed from normal to low

Good thing is, they're not completely inaccessible, as you can click the top-level item. Having 30 pages under Settings is not entirely crazy, so I understand this.

What I'd like to see for 3.3 is for the flyouts to not hide under the admin bar when the submenus reproduce like rabbits. At least then it'll feel usable. Full accessibility can be punted. It can be noted that other workarounds include A) tabbing through o and B) scrolling with a mouse wheel or trackpad.

comment:2 nacin2 years ago

  • Component changed from Menus to Administration

"Menus" is for Appearance > Menus. Yeah, it's confusing.

devinreams2 years ago

Don't offset the margin for really tall sub-menus (which ends up being negative) if taller than the window

comment:3 devinreams2 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

What I'd like to see for 3.3 is for the flyouts to not hide under the admin bar when the submenus reproduce like rabbits.

What if we tell the JS not to add the margin-top in the case it's taller than the window? I'm not sure my approach is sound here. Testing needed.

devinreams2 years ago

Actually, let's slide the flyout up a bit. This way we can see it and it doesn't break the page if it has to go too low (e.g.: add options-general.php to the test plugin).

comment:4 azaozz2 years ago

  • Milestone changed from 3.3 to Future Release

When you click on the top menu, the submenus are shown underneath, scrollable. Seems this is just a rare edge case that can wait for 3.4.

comment:5 nacin2 years ago

  • Milestone changed from Future Release to 3.3

Marked #19362 as a duplicate. There, there is a screenshot that's certainly within the realm of possibility.

Let's review and clean up devinreams' approaches and put this in for 3.3. At least make it not look so obviously broken.

comment:6 nacin2 years ago

  • Owner set to azaozz
  • Status changed from new to assigned

azaozz is going to take a look.

Desired 3.3 behavior: The top of the flyout is not hidden under the admin bar.

comment:7 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In [19487]:

When the submenu is too long to fit on the screen, place the top if it under the admin bar (the rest is scrollable with a wheel mouse), fixes #19323

comment:8 DrewAPicture2 years ago

Version 2, edited 2 years ago by DrewAPicture (previous) (next) (diff)
Note: See TracTickets for help on using tickets.