WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19327 closed defect (bug) (fixed)

Edit comments and new content items shouldn't be displayed in network admin

Reported by: ocean90 Owned by: ryan
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: Toolbar Keywords: has-patch
Focuses: Cc:

Description

At the moment I'm not sure how it was in 3.2, but the edit comments link and new content items don't make sense in network admin IMO.

There is also the new->user item which is linked to wp-admin/new-user.php. But here somebody could think "okay, I'm on network admin so it will link to wp-admin/network/user.php", but it doesn't.

Needs some UI/UX feedback.

Attachments (4)

19327.wp32.png (12.9 KB) - added by SergeyBiryukov 2 years ago.
19327.wp33.png (13.2 KB) - added by SergeyBiryukov 2 years ago.
19327.patch (1.0 KB) - added by SergeyBiryukov 2 years ago.
19327.2.patch (814 bytes) - added by ocean90 2 years ago.

Download all attachments as: .zip

Change History (11)

SergeyBiryukov2 years ago

SergeyBiryukov2 years ago

comment:1 SergeyBiryukov2 years ago

In 3.2, there were no "Edit Comments" or "Add New" links in Network Admin (attached screenshots).

SergeyBiryukov2 years ago

ocean902 years ago

comment:2 ocean902 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.3

In my patch I wrapped only comments menu and new content menu, like we did it in 3.2.

Last edited 2 years ago by ocean90 (previous) (diff)

comment:3 scribu2 years ago

The "Add New" menu should contain "Add Site" and "Add User", both pointing to the appropriate network screens.

comment:4 SergeyBiryukov2 years ago

BTW, shouldn't "Edit Comment" icon have a tooltip, like the "Updates" item?

Version 0, edited 2 years ago by SergeyBiryukov (next)

comment:5 jane2 years ago

  • Keywords ui-feedback removed

I agree. Comments and Add New are site-specific things, don't belong in Network Admin. Yes to comments tooltip also.

comment:6 ryan2 years ago

  • Owner set to ryan
  • Resolution set to fixed
  • Status changed from new to closed

In [19398]:

Don't show Add New and Comments admin bar menus in network or user admins. Add tooltip to comments menu. Props ocean90. fixes #19327

comment:7 ryan2 years ago

In [19399]:

Don't forget esc_attr(). see #19327

Note: See TracTickets for help on using tickets.