WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#19331 closed defect (bug) (fixed)

Login screen isn't centered on iPhone

Reported by: ocean90 Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: UI Keywords: has-patch regression
Focuses: Cc:

Description

See attached screenshots from iPhone.

Attachments (8)

iOS Simulator Bildschirmfoto 22.11.2011 17.58.39.png (33.6 KB) - added by ocean90 4 years ago.
WP 3.3
iOS Simulator Bildschirmfoto 22.11.2011 17.58.53.png (38.0 KB) - added by ocean90 4 years ago.
WP 3.2
19331.patch (323 bytes) - added by SergeyBiryukov 4 years ago.
19331.2.patch (333 bytes) - added by ocean90 4 years ago.
margin instead of padding
19331.3.patch (496 bytes) - added by SergeyBiryukov 4 years ago.
19331.diff (428 bytes) - added by helenyhou 4 years ago.
Based off of SergeyBiryukov's patch
19331.4.patch (581 bytes) - added by SergeyBiryukov 4 years ago.
19331.5.patch (613 bytes) - added by SergeyBiryukov 4 years ago.

Download all attachments as: .zip

Change History (19)

#1 @jane
4 years ago

  • Keywords has-patch added; needs-patch removed

@ocean90
4 years ago

margin instead of padding

#2 follow-up: @ocean90
4 years ago

19331.2.patch does fix it for me.

#3 @ocean90
4 years ago

  • Keywords early added
  • Milestone changed from 3.3 to Future Release

#4 @helenyhou
4 years ago

19331.2.patch has the white stripe at the top again: http://cl.ly/0E1U3y0507410n332v3O

#5 @nacin
4 years ago

  • Keywords regression added

Technically a regression, yeah? Would be nice to fix.

#6 in reply to: ↑ 2 @SergeyBiryukov
4 years ago

Replying to ocean90:

19331.2.patch does fix it for me.

That would revert [18737].

#7 @SergeyBiryukov
4 years ago

  • Keywords early removed
  • Milestone changed from Future Release to 3.3

19331.3.patch adjusts wp-login.php for [18737].

@helenyhou
4 years ago

Based off of SergeyBiryukov's patch

#8 @helenyhou
4 years ago

19331.diff is based off of SergeyBiryukov's patch, adds some space below as well. Didn't even realize there was iPhone magic there :)

#9 @SergeyBiryukov
4 years ago

19331.5.patch also aligns messages, navigation links and header image.

#10 @helenyhou
4 years ago

Looks good to me. Better than 3.2.1, even.

#11 @azaozz
4 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19414]:

Align login box, messages, navigation links and header image on the login screen, props SergeyBiryukov and helenyhou, fixes #19331

Note: See TracTickets for help on using tickets.