WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#19331 closed defect (bug) (fixed)

Login screen isn't centered on iPhone

Reported by: ocean90 Owned by: azaozz
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: UI Keywords: has-patch regression
Focuses: Cc:

Description

See attached screenshots from iPhone.

Attachments (8)

iOS Simulator Bildschirmfoto 22.11.2011 17.58.39.png (33.6 KB) - added by ocean90 3 years ago.
WP 3.3
iOS Simulator Bildschirmfoto 22.11.2011 17.58.53.png (38.0 KB) - added by ocean90 3 years ago.
WP 3.2
19331.patch (323 bytes) - added by SergeyBiryukov 3 years ago.
19331.2.patch (333 bytes) - added by ocean90 3 years ago.
margin instead of padding
19331.3.patch (496 bytes) - added by SergeyBiryukov 3 years ago.
19331.diff (428 bytes) - added by helenyhou 3 years ago.
Based off of SergeyBiryukov's patch
19331.4.patch (581 bytes) - added by SergeyBiryukov 3 years ago.
19331.5.patch (613 bytes) - added by SergeyBiryukov 3 years ago.

Download all attachments as: .zip

Change History (19)

@SergeyBiryukov3 years ago

comment:1 @jane3 years ago

  • Keywords has-patch added; needs-patch removed

@ocean903 years ago

margin instead of padding

comment:2 follow-up: @ocean903 years ago

19331.2.patch does fix it for me.

comment:3 @ocean903 years ago

  • Keywords early added
  • Milestone changed from 3.3 to Future Release

comment:5 @nacin3 years ago

  • Keywords regression added

Technically a regression, yeah? Would be nice to fix.

comment:6 in reply to: ↑ 2 @SergeyBiryukov3 years ago

Replying to ocean90:

19331.2.patch does fix it for me.

That would revert [18737].

@SergeyBiryukov3 years ago

comment:7 @SergeyBiryukov3 years ago

  • Keywords early removed
  • Milestone changed from Future Release to 3.3

19331.3.patch adjusts wp-login.php for [18737].

@helenyhou3 years ago

Based off of SergeyBiryukov's patch

comment:8 @helenyhou3 years ago

19331.diff is based off of SergeyBiryukov's patch, adds some space below as well. Didn't even realize there was iPhone magic there :)

@SergeyBiryukov3 years ago

@SergeyBiryukov3 years ago

comment:9 @SergeyBiryukov3 years ago

19331.5.patch also aligns messages, navigation links and header image.

comment:10 @helenyhou3 years ago

Looks good to me. Better than 3.2.1, even.

comment:11 @azaozz3 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19414]:

Align login box, messages, navigation links and header image on the login screen, props SergeyBiryukov and helenyhou, fixes #19331

Note: See TracTickets for help on using tickets.