WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#19335 closed defect (bug) (fixed)

Make feature pointers nice for our RTL users

Reported by: ocean90 Owned by: koopersmith
Milestone: 3.3 Priority: normal
Severity: normal Version: 3.3
Component: UI Keywords:
Focuses: Cc:

Description


Attachments (2)

19335.diff (1.5 KB) - added by helenyhou 2 years ago.
First pass
19335.2.diff (1.7 KB) - added by helenyhou 2 years ago.
+ Dismiss link

Download all attachments as: .zip

Change History (8)

helenyhou2 years ago

First pass

comment:1 helenyhou2 years ago

19335.diff is a first pass - not sure if I'm approaching this the right way. A little CSS and ternary for align/edge.

Issue: media pointer is not quite right (and too high, as I'm in FF - see #18693]

http://f.cl.ly/items/3g1w311C3T3p390q1p1f/Screen%20Shot%202011-11-23%20at%209.29.40%20AM.png

comment:2 follow-up: ocean902 years ago

From your screenshot it seems like the dismiss link is on the wrong side.

helenyhou2 years ago

+ Dismiss link

comment:3 in reply to: ↑ 2 helenyhou2 years ago

Replying to ocean90:

From your screenshot it seems like the dismiss link is on the wrong side.

You are correct. 19335.2.diff adds some CSS for the dismiss/close link.

comment:4 jane2 years ago

For the record, the dimiss link would be fine on the other side if need be.

comment:5 koopersmith2 years ago

  • Owner set to koopersmith
  • Resolution set to fixed
  • Status changed from new to closed

In [19419]:

RTL styles for pointers. props helenyhou, fixes #19335.

comment:6 koopersmith2 years ago

  • Keywords needs-patch removed
Note: See TracTickets for help on using tickets.