Insert image from url not working on Press This

[ronbme]

The insert image from url is not working on Press This.
If the image does not show up in the preview window, there is no other way to insert the image.

I did a copy and paste on the image location and then clicked to insert it in the post. Nothing shows up.

This is using WP 3.3. trunk 19414.

Problem has existed for all versions of WP 3.3

[jane]

@nacin: is this a regression? I have a buggy Press This now too, though wouldn't prioritize it and am not sure if it was working better in 3.2.
(Also, shouldn't we be pulling it out into a plugin? We should remember to do that.)

[nacin]

Press This really isn't that difficult. It's just always had an ugly and neglected codebase. It should remain in core and be supplemented by browser extensions to replace the bookmarklet. It just needs the love of an enterprising developer for a single release.

It doesn't rely on the media code, it has it's own, so this wasn't broken from the media button merge work, AFAICT.

[duck_]

Caused by [19381] which caused image_selector() to use #tb_this_photo and #tb_this_photo_description. #photo-add-url-div also uses image_selector(), but it's inputs don't have the tb_ prefix.

[ronbme]

Replying to jane:

@nacin: is this a regression? I have a buggy Press This now too, though wouldn't prioritize it and am not sure if it was working better in 3.2.
(Also, shouldn't we be pulling it out into a plugin? We should remember to do that.)

There is a plugin named "Press This Reloaded". It actually goes further than Press This. But, unfortunately, it hasn't been updated.

[azaozz]

In [19424]:

Fix inserting images from url in Press This, fixes #19341

[nacin]

The margin: 10px pretty obviously broke styling of the stuffboxes.

[nacin]

​http://cl.ly/2p27153m3s1E2B3X1x29

[nacin]

In [19491]:

Remove margin from h3's in press this. fixes #19341.

[azaozz]

In [19492]:

Fix css selectors mismatch in Press This, see #19341