"(from previous theme)" remains cut off, and description still needs work

[nacin]

​http://cl.ly/330B1w1G3i3h0e3l3b2z

Inactive Sidebar (from previous theme)

This is a left over sidebar from an old theme and does not show anywhere on your site

Some good ideas from chrisbliss18 in #17979, comment 117.

[ocean90]

I thought this has been fixed? See #19092

[ocean90]

I tested it with current trunk and can't reproduce the cut off issue, because the sidebar is now on the left side.

[nacin]

This is trunk, 1440 pixels wide: ​http://cl.ly/0O0B0z3H023S0l2M3m3A.

[ocean90]

Mhh, this is a bug I think. IMO the inactive sidebar should be always on the left side: ​http://cl.ly/C3rb

[nacin]

I'm not sure I'd disagree, but not once in testing have I seen them on the left.

[azaozz]

Replying to nacin:

Is this with a theme that doesn't have any sidebars/no widgets support? If yes it seems like a different issue, don't think we show a widgets screen for themes that don't support them.

[nacin]

Replying to azaozz:

Replying to nacin:

Is this with a theme that doesn't have any sidebars/no widgets support? If yes it seems like a different issue, don't think we show a widgets screen for themes that don't support them.

No, it's not.

[ocean90]

Nacin, I can reproduce your screen if I comment all widgets sidebars out, does it makes sense?

[azaozz]

Replying to nacin:

No, it's not.

That's strange, there are no "real" sidebars on ​http://cl.ly/0O0B0z3H023S0l2M3m3A, looks like there aren't any registered by the theme or something else it mangling them.

[nacin]

Test code is mangling them. The first screenshot was when there was one inactive sidebar and four active ones.

I don't understand how the code is to frail to ever render this on the right.

[azaozz]

Then the bug here is that we even display anything on that screen. Should exit early with a message that the theme doesn't support widgets IMHO (the previous behavior?).

[nacin]

Assign a widget to each of Twenty Eleven's sidebars.

Go into the code and comment out registration of one or more sidebars.

You'll find the inactive sidebar on right, cut off.

I've yet to see the inactive sidebar in the left side.

[nacin]

Replying to nacin:

I've yet to see the inactive sidebar in the left side.

As in, I still have no idea how this feature is supposed to work, and every time I have tried to test it, I break it.

[nacin]

Chris's strings were a pretty good first pass, and better than what we have:

Inactive Sidebar (not used)

This sidebar is no longer available and does not show anywhere on your site. Remove each of the widgets below to fully remove this inactive sidebar.

[nacin]

It's clear something is broken here. This is no longer a pure UI issue.

[jane]

Replying to nacin:

As in, I still have no idea how this feature is supposed to work, and every time I have tried to test it, I break it.

You and me both.

[azaozz]

In [19452]:

Make sure all orphaned sidebars are shown on the left (under Available Widgets), see #19350

[SergeyBiryukov]

19350.patch​ was an attempt to make sure an inactive sidebar would only appear on the left and to update the strings as per chrisbliss18's suggestion.

[19452] solves the position issue in a more elegant way, so 19350.2.patch​ is just a refresh of chrisbliss18's patch from #17979.

[azaozz]

In [19453]:

Update the text for inactive sidebars, props chrisbliss18 SergeyBiryukov, fixes #19350

[azaozz]

Replying to SergeyBiryukov:

Sorry, committed [19452] before seeing your patch (they are 1 min. apart). Both should work well.

[azaozz]

[19452] seems to interfere with #19274. Changed sidebars in the same theme don't work right.

[azaozz]

In [19455]:

Check the sidebar class for orphaned sidebars, match sidebars by id while retrieving orphans and the theme has not changed, props SergeyBiryukov, fixes #19350