WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#19350 closed defect (bug) (fixed)

"(from previous theme)" remains cut off, and description still needs work

Reported by: nacin Owned by: azaozz
Milestone: 3.3 Priority: high
Severity: major Version:
Component: Widgets Keywords: needs-patch
Focuses: Cc:

Description (last modified by nacin)

http://cl.ly/330B1w1G3i3h0e3l3b2z

Inactive Sidebar (from previous theme)

This is a left over sidebar from an old theme and does not show anywhere on your site

Some good ideas from chrisbliss18 in #17979, comment 117.

Attachments (2)

19350.patch (2.0 KB) - added by SergeyBiryukov 2 years ago.
19350.2.patch (965 bytes) - added by SergeyBiryukov 2 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 ocean902 years ago

I thought this has been fixed? See #19092

comment:2 ocean902 years ago

I tested it with current trunk and can't reproduce the cut off issue, because the sidebar is now on the right side.

Version 0, edited 2 years ago by ocean90 (next)

comment:3 follow-up: nacin2 years ago

This is trunk, 1440 pixels wide: http://cl.ly/0O0B0z3H023S0l2M3m3A.

comment:4 ocean902 years ago

Mhh, this is a bug I think. IMO the inactive sidebar should be always on the left side: http://cl.ly/C3rb

comment:5 nacin2 years ago

I'm not sure I'd disagree, but not once in testing have I seen them on the left.

comment:6 in reply to: ↑ 3 ; follow-up: azaozz2 years ago

Replying to nacin:

Is this with a theme that doesn't have any sidebars/no widgets support? If yes it seems like a different issue, don't think we show a widgets screen for themes that don't support them.

comment:7 in reply to: ↑ 6 ; follow-up: nacin2 years ago

Replying to azaozz:

Replying to nacin:

Is this with a theme that doesn't have any sidebars/no widgets support? If yes it seems like a different issue, don't think we show a widgets screen for themes that don't support them.

No, it's not.

comment:8 ocean902 years ago

Nacin, I can reproduce your screen if I comment all widgets sidebars out, does it makes sense?

Last edited 2 years ago by ocean90 (previous) (diff)

comment:9 in reply to: ↑ 7 azaozz2 years ago

Replying to nacin:

No, it's not.

That's strange, there are no "real" sidebars on http://cl.ly/0O0B0z3H023S0l2M3m3A, looks like there aren't any registered by the theme or something else it mangling them.

comment:10 nacin2 years ago

  • Description modified (diff)

Test code is mangling them. The first screenshot was when there was one inactive sidebar and four active ones.

I don't understand how the code is to frail to ever render this on the right.

comment:11 azaozz2 years ago

Then the bug here is that we even display anything on that screen. Should exit early with a message that the theme doesn't support widgets IMHO (the previous behavior?).

In any case we can shorten the text and expand the explanation a bit, anything that makes it clearer what's going on is a plus.

Last edited 2 years ago by azaozz (previous) (diff)

comment:12 follow-up: nacin2 years ago

  • Keywords needs-patch added

Assign a widget to each of Twenty Eleven's sidebars.

Go into the code and comment out registration of one or more sidebars.

You'll find the inactive sidebar on right, cut off.

I've yet to see the inactive sidebar in the left side.

comment:13 in reply to: ↑ 12 ; follow-up: nacin2 years ago

Replying to nacin:

I've yet to see the inactive sidebar in the left side.

As in, I still have no idea how this feature is supposed to work, and every time I have tried to test it, I break it.

comment:14 nacin2 years ago

Chris's strings were a pretty good first pass, and better than what we have:

Inactive Sidebar (not used)

This sidebar is no longer available and does not show anywhere on your site. Remove each of the widgets below to fully remove this inactive sidebar.

comment:15 nacin2 years ago

  • Component changed from UI to Widgets
  • Priority changed from normal to high
  • Severity changed from normal to major

It's clear something is broken here. This is no longer a pure UI issue.

comment:16 in reply to: ↑ 13 jane2 years ago

Replying to nacin:

As in, I still have no idea how this feature is supposed to work, and every time I have tried to test it, I break it.

You and me both.

SergeyBiryukov2 years ago

comment:17 azaozz2 years ago

In [19452]:

Make sure all orphaned sidebars are shown on the left (under Available Widgets), see #19350

SergeyBiryukov2 years ago

comment:18 follow-up: SergeyBiryukov2 years ago

19350.patch was an attempt to make sure an inactive sidebar would only appear on the left and to update the strings as per chrisbliss18's suggestion.

[19452] solves the position issue in a more elegant way, so 19350.2.patch is just a refresh of chrisbliss18's patch from #17979.

Last edited 2 years ago by SergeyBiryukov (previous) (diff)

comment:19 azaozz2 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In [19453]:

Update the text for inactive sidebars, props chrisbliss18 SergeyBiryukov, fixes #19350

comment:20 in reply to: ↑ 18 azaozz2 years ago

Replying to SergeyBiryukov:

Sorry, committed [19452] before seeing your patch (they are 1 min. apart). Both should work well.

comment:21 azaozz2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

[19452] seems to interfere with #19274. Changed sidebars in the same theme don't work right.

comment:22 azaozz2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In [19455]:

Check the sidebar class for orphaned sidebars, match sidebars by id while retrieving orphans and the theme has not changed, props SergeyBiryukov, fixes #19350

Note: See TracTickets for help on using tickets.